This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Switch to the new testing configurations by default
ClosedPublic

Authored by ldionne on Mar 14 2022, 12:03 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGd0af4276d624: [libc++] Switch to the new testing configurations by default
Summary

We've been meaning to remove support for the legacy testing configuration
for a long time. This patch switches the default from the legacy config
to the appropriate new-style configuration based on a few hints.

We've been running with the new-style configuration for more than a year
in our CI, however it's possible that this will uncover issues with some
users that run the tests on platforms that we don't support yet with the
new-style configs. Unfortunately, there is no way to know about it other
than to land this patch and see whether anything breaks.

Diff Detail

Event Timeline

ldionne created this revision.Mar 14 2022, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 12:03 PM
ldionne requested review of this revision.Mar 14 2022, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 12:03 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo added inline comments.Mar 14 2022, 12:41 PM
libcxx/CMakeLists.txt
143

This is all a matter of taste, but I'd find elseif(MINGW) elseif(WIN32) #clang-cl elseif(... more straightforward, instead of the WIN32 AND NOT MINGW followed by the complement of the negation.

Alternatively, depending on which one to single out, one could also use elseif (MSVC) # clang-cl elseif (MINGW), as MSVC is defined in clang-cl configurations.

ldionne added inline comments.Mar 14 2022, 1:47 PM
libcxx/CMakeLists.txt
143

You're right, I'll improve this in the next rev.

ldionne updated this revision to Diff 415212.Mar 14 2022, 1:52 PM
ldionne marked an inline comment as done.

Address comments and add message to show which config we're using

ldionne updated this revision to Diff 415875.Mar 16 2022, 9:44 AM

Rebase onto main -- that should fix the bootstrapping build.

ldionne accepted this revision as: Restricted Project.Mar 16 2022, 1:41 PM

I will land this tomorrow morning and watch out for any fallout this might have. I hope it won't but it might break some builders that use configurations we don't test in CI right now.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2022, 11:27 AM
This revision was automatically updated to reflect the committed changes.