This is an archive of the discontinued LLVM Phabricator instance.

[libc][NFC] split standalone_cpp into single headers
ClosedPublic

Authored by michaelrj on Mar 8 2022, 11:19 AM.

Details

Summary

Previously, the entire support/CPP folder was in one header library,
which meant that a lot of headers were included where they shouldn't be.
This patch splits each header into its own target, as well as adjusting
each place they were included to only include what is used.

Diff Detail

Event Timeline

michaelrj created this revision.Mar 8 2022, 11:19 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 8 2022, 11:19 AM
michaelrj requested review of this revision.Mar 8 2022, 11:19 AM
sivachandra accepted this revision.Mar 8 2022, 11:34 AM
This revision is now accepted and ready to land.Mar 8 2022, 11:34 AM
lntue accepted this revision.Mar 8 2022, 11:47 AM
lntue added inline comments.
libc/src/__support/FPUtil/CMakeLists.txt
2

nit: separate

libc/src/string/memory_utils/CMakeLists.txt
12

nit: alignment

michaelrj updated this revision to Diff 413894.Mar 8 2022, 11:55 AM

address comments

This revision was landed with ongoing or failed builds.Mar 8 2022, 11:56 AM
This revision was automatically updated to reflect the committed changes.