This is an archive of the discontinued LLVM Phabricator instance.

Differential D121218

[flang][nfc] Update the CMake dependencies for `flangFrontend`
ClosedPublic

Authored by awarzynski on Mar 8 2022, 7:35 AM.

Details

Reviewers
DavidSpickett
Commits
rGb383b17bf7af: [flang][nfc] Update the CMake dependencies for `flangFrontend`
Summary

The "FrontendActions.cpp" file (which is one of the source files for the
flangFrontend library) includes "Passes.h.inc" (indirectly, via
"CLOptions.inc"). This file is generated alongside other TableGen
outputs from the FIROptTransformsPassIncGen CMake target. This patch
adds FIROptTransformsPassIncGen to the list of build dependencies for
flangFrontend.

The lack of this dependency might cause non-determinstic build failures,
e.g. https://lab.llvm.org/buildbot/#/builders/160/builds/6210.

Diff Detail

Event Timeline

awarzynski created this revision.Mar 8 2022, 7:35 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 8 2022, 7:35 AM
Herald added a subscriber: mgorny. · View Herald Transcript
awarzynski requested review of this revision.Mar 8 2022, 7:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 7:35 AM
Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript
DavidSpickett accepted this revision.Mar 8 2022, 7:38 AM

LGTM

This revision is now accepted and ready to land.Mar 8 2022, 7:38 AM
Harbormaster completed remote builds in B153155: Diff 413803.Mar 8 2022, 7:51 AM
Closed by commit rGb383b17bf7af: [flang][nfc] Update the CMake dependencies for `flangFrontend` (authored by awarzynski). · Explain WhyMar 8 2022, 9:20 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rGb383b17bf7af: [flang][nfc] Update the CMake dependencies for `flangFrontend`.

Revision Contents

PathSize
flang/
lib/
Frontend/
1 line

Diff 413831

flang/lib/Frontend/CMakeLists.txt

Show All 9 Linesadd_flang_library(flangFrontend
TextDiagnosticBuffer.cpp TextDiagnosticBuffer.cpp
TextDiagnostic.cpp TextDiagnostic.cpp
DEPENDS DEPENDS
clangBasic clangBasic
FIRBuilder FIRBuilder
FIRDialect FIRDialect
FIRSupport FIRSupport
FIROptTransformsPassIncGen
MLIRIR MLIRIR
${dialect_libs} ${dialect_libs}
LINK_LIBS LINK_LIBS
FortranParser FortranParser
FortranSemantics FortranSemantics
FortranEvaluate FortranEvaluate
FortranCommon FortranCommon
Show All 19 Lines