This is an archive of the discontinued LLVM Phabricator instance.

Differential D121215

[cmake] Add LLVM_THINLTO_CACHE_PATH
ClosedPublic

Authored by thieta on Mar 8 2022, 7:19 AM.

Details

Reviewers
phosek
Commits
rGc572c6ae5627: [cmake] Add LLVM_THINLTO_CACHE_PATH
Summary

This allows you to set a custom path to the ThinLTO cache so that
it can be shared when building in several different build directories.

Diff Detail

Unit TestsFailed

TimeTest
60,090 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
60,130 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,120 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg_mask.c
33,110 msx64 debian > libFuzzer.libFuzzer::fork.test
1,850 msx64 debian > libFuzzer.libFuzzer::fuzzer-finalstats.test
View Full Test Results (11 Failed)

Event Timeline

thieta created this revision.Mar 8 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 7:19 AM
Herald added subscribers: inglorion, mgorny. · View Herald Transcript
thieta requested review of this revision.Mar 8 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 7:20 AM
Harbormaster completed remote builds in B153149: Diff 413798.Mar 8 2022, 7:53 AM
thieta added a comment.Mar 11 2022, 3:01 AM

ping

phosek accepted this revision.Mar 11 2022, 12:16 PM

LGTM

llvm/cmake/modules/HandleLLVMOptions.cmake
1085

Typo

This revision is now accepted and ready to land.Mar 11 2022, 12:16 PM
This revision was landed with ongoing or failed builds.Mar 13 2022, 11:47 PM
Closed by commit rGc572c6ae5627: [cmake] Add LLVM_THINLTO_CACHE_PATH (authored by thieta). · Explain Why
This revision was automatically updated to reflect the committed changes.
thieta added a commit: rGc572c6ae5627: [cmake] Add LLVM_THINLTO_CACHE_PATH.

Revision Contents

PathSize
llvm/
cmake/
modules/
10 lines

Diff 413798

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 1,076 Lines • ▼ Show 20 Linesappend_if(LLVM_BUILD_INSTRUMENTED_COVERAGE "-fprofile-instr-generate=\"${LLVM_PROFILE_FILE_PATTERN}\" -fcoverage-mapping"
CMAKE_C_FLAGS CMAKE_C_FLAGS
CMAKE_EXE_LINKER_FLAGS CMAKE_EXE_LINKER_FLAGS
CMAKE_SHARED_LINKER_FLAGS) CMAKE_SHARED_LINKER_FLAGS)
if (LLVM_BUILD_INSTRUMENTED AND LLVM_BUILD_INSTRUMENTED_COVERAGE) if (LLVM_BUILD_INSTRUMENTED AND LLVM_BUILD_INSTRUMENTED_COVERAGE)
message(FATAL_ERROR "LLVM_BUILD_INSTRUMENTED and LLVM_BUILD_INSTRUMENTED_COVERAGE cannot both be specified") message(FATAL_ERROR "LLVM_BUILD_INSTRUMENTED and LLVM_BUILD_INSTRUMENTED_COVERAGE cannot both be specified")
endif() endif()
set(LLVM_THINLTO_CACHE_PATH "${PROJECT_BINARY_DIR}/lto.cache" CACHE STRING "Set ThinLTO cache path. This can be used when building LLVM from several different directiories.")
phosekUnsubmitted
Not Done
ReplyInline Actions
endif()
- set(LLVM_THINLTO_CACHE_PATH "${PROJECT_BINARY_DIR}/lto.cache" CACHE STRING "Set ThinLTO cache path. This can be used when building LLVM from several different directiories.")
+ set(LLVM_THINLTO_CACHE_PATH "${PROJECT_BINARY_DIR}/lto.cache" CACHE STRING "Set ThinLTO cache path. This can be used when building LLVM from several different directories.")
if(LLVM_ENABLE_LTO AND LLVM_ON_WIN32 AND NOT LINKER_IS_LLD_LINK AND NOT MINGW)

Typo

phosek: Typo
if(LLVM_ENABLE_LTO AND LLVM_ON_WIN32 AND NOT LINKER_IS_LLD_LINK AND NOT MINGW) if(LLVM_ENABLE_LTO AND LLVM_ON_WIN32 AND NOT LINKER_IS_LLD_LINK AND NOT MINGW)
message(FATAL_ERROR "When compiling for Windows, LLVM_ENABLE_LTO requires using lld as the linker (point CMAKE_LINKER at lld-link.exe)") message(FATAL_ERROR "When compiling for Windows, LLVM_ENABLE_LTO requires using lld as the linker (point CMAKE_LINKER at lld-link.exe)")
endif() endif()
if(uppercase_LLVM_ENABLE_LTO STREQUAL "THIN") if(uppercase_LLVM_ENABLE_LTO STREQUAL "THIN")
append("-flto=thin" CMAKE_CXX_FLAGS CMAKE_C_FLAGS) append("-flto=thin" CMAKE_CXX_FLAGS CMAKE_C_FLAGS)
if(NOT LINKER_IS_LLD_LINK) if(NOT LINKER_IS_LLD_LINK)
append("-flto=thin" CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) append("-flto=thin" CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
endif() endif()
# If the linker supports it, enable the lto cache. This improves initial build # If the linker supports it, enable the lto cache. This improves initial build
# time a little since we re-link a lot of the same objects, and significantly # time a little since we re-link a lot of the same objects, and significantly
# improves incremental build time. # improves incremental build time.
# FIXME: We should move all this logic into the clang driver. # FIXME: We should move all this logic into the clang driver.
if(APPLE) if(APPLE)
append("-Wl,-cache_path_lto,${PROJECT_BINARY_DIR}/lto.cache" append("-Wl,-cache_path_lto,${LLVM_THINLTO_CACHE_PATH}"
CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
elseif((UNIX OR MINGW) AND LLVM_USE_LINKER STREQUAL "lld") elseif((UNIX OR MINGW) AND LLVM_USE_LINKER STREQUAL "lld")
append("-Wl,--thinlto-cache-dir=${PROJECT_BINARY_DIR}/lto.cache" append("-Wl,--thinlto-cache-dir=${LLVM_THINLTO_CACHE_PATH}"
CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
elseif(LLVM_USE_LINKER STREQUAL "gold") elseif(LLVM_USE_LINKER STREQUAL "gold")
append("-Wl,--plugin-opt,cache-dir=${PROJECT_BINARY_DIR}/lto.cache" append("-Wl,--plugin-opt,cache-dir=${LLVM_THINLTO_CACHE_PATH}"
CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
elseif(LINKER_IS_LLD_LINK) elseif(LINKER_IS_LLD_LINK)
append("/lldltocache:${PROJECT_BINARY_DIR}/lto.cache" append("/lldltocache:${LLVM_THINLTO_CACHE_PATH}"
CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
endif() endif()
elseif(uppercase_LLVM_ENABLE_LTO STREQUAL "FULL") elseif(uppercase_LLVM_ENABLE_LTO STREQUAL "FULL")
append("-flto=full" CMAKE_CXX_FLAGS CMAKE_C_FLAGS) append("-flto=full" CMAKE_CXX_FLAGS CMAKE_C_FLAGS)
if(NOT LINKER_IS_LLD_LINK) if(NOT LINKER_IS_LLD_LINK)
append("-flto=full" CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) append("-flto=full" CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
endif() endif()
elseif(LLVM_ENABLE_LTO) elseif(LLVM_ENABLE_LTO)
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines