Page MenuHomePhabricator
Differential D121041

[AVR] Fix incorrect calling convention for varargs functions
AbandonedPublic
Actions

Authored by benshi001 on Mar 4 2022, 10:39 PM.

Details

Reviewers
dylanmckay
aykevl
Summary

An i8 argument should only cost 1 byte on the stack. This is
compatible with avr-gcc.

There are also more test cases (of calling convention) are added.

Diff Detail

Event Timeline

benshi001 created this revision.Mar 4 2022, 10:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 10:39 PM
Herald added subscribers: Jim, hiraditya. · View Herald Transcript
benshi001 requested review of this revision.Mar 4 2022, 10:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 10:39 PM
Herald added subscribers: llvm-commits, jacquesguan. · View Herald Transcript
Harbormaster completed remote builds in B152713: Diff 413199.Mar 4 2022, 11:02 PM
benshi001 updated this revision to Diff 413204.Mar 5 2022, 12:15 AM
Harbormaster completed remote builds in B152718: Diff 413204.Mar 5 2022, 12:53 AM
benshi001 updated this revision to Diff 413206.Mar 5 2022, 2:14 AM
Harbormaster completed remote builds in B152720: Diff 413206.Mar 5 2022, 2:42 AM
benshi001 updated this revision to Diff 414545.Mar 10 2022, 6:22 PM
Harbormaster completed remote builds in B153689: Diff 414545.Mar 10 2022, 7:17 PM
benshi001 added a comment.Mar 12 2022, 10:54 PM

This patch fixes the bug https://github.com/llvm/llvm-project/issues/54148 .

benshi001 added a comment.Mar 15 2022, 12:23 AM
This comment was removed by benshi001.
benshi001 added a parent revision: D118354: [AVR][NFC] Fix incorrect register states in expanding pseudo instructions.Mar 15 2022, 3:54 AM
benshi001 updated this revision to Diff 415379.Mar 15 2022, 3:58 AM

This patch fixes the bug https://github.com/llvm/llvm-project/issues/54148 .

Harbormaster completed remote builds in B154291: Diff 415379.Mar 15 2022, 4:29 AM
benshi001 added a comment.Mar 15 2022, 4:45 AM

The build failures are not related to AVR and are not caused by this patch.

benshi001 updated this revision to Diff 415676.Mar 15 2022, 7:50 PM
Harbormaster completed remote builds in B154494: Diff 415676.Mar 15 2022, 7:51 PM
benshi001 updated this revision to Diff 415678.Mar 15 2022, 8:00 PM
benshi001 removed a parent revision: D118354: [AVR][NFC] Fix incorrect register states in expanding pseudo instructions.
Harbormaster completed remote builds in B154497: Diff 415678.Mar 15 2022, 8:01 PM
benshi001 abandoned this revision.Mar 15 2022, 8:10 PM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AVR/
2 lines
test/
CodeGen/
AVR/
calling-conv/
c/
74 lines
93 lines
111 lines

Diff 415678

View Options

llvm/lib/Target/AVR/AVRCallingConv.td

Loading...
View Options

llvm/test/CodeGen/AVR/calling-conv/c/basic.ll

Loading...
View Options

llvm/test/CodeGen/AVR/calling-conv/c/basic_aggr.ll

Loading...
View Options

llvm/test/CodeGen/AVR/calling-conv/c/stack.ll

Loading...