[compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2.

[compnerd]

Can you define an use a macro similar to ARM_EABI_FNALIAS in int_lib.h please?

[jmgao]

Add and use an FNALIAS macro

[compnerd]

lib/builtins/comparedf2.c

83

Use /* */, since I don't believe we are forcing C99. Similar throughout.

lib/builtins/int_lib.h

23

clang-format this line please.

[jmgao]

lib/builtins/comparedf2.c

83

These files only have // comments, and there are a bunch of other ones that are similar.

[compnerd]

lib/builtins/comparedf2.c

83

Okay, seems fair enough

[asl]

lib/builtins/int_lib.h

23

What's in darwin case? Shall we define these aliases there as well?

[jmgao]

lib/builtins/int_lib.h

23

This will be defined for everything that includes int_lib.h

[jmgao]

lib/builtins/int_lib.h

23

Sorry, misread your comment. I'm not sure what should happen in darwin.

[compnerd]

lib/builtins/int_lib.h

23

Darwin did at one point use libgcc, so I don't think that this would be problematic. Do you have some reason to believe it would be? We could easily conditionalise the aliases if that is the case.

lib/builtins/comparedf2.c

     }
 }
 
+// Alias for libgcc compatibility
+FNALIAS(__cmpdf2, __ledf2);
+
 enum GE_RESULT {
     GE_LESS      = -1,
     GE_EQUAL     =  0,

lib/builtins/comparesf2.c

     }
 }
 
+// Alias for libgcc compatibility
+FNALIAS(__cmpsf2, __lesf2);
+
 enum GE_RESULT {
     GE_LESS      = -1,
     GE_EQUAL     =  0,

lib/builtins/comparetf2.c

     }
 }
 
+// Alias for libgcc compatibility
+FNALIAS(__cmptf2, __letf2);
+
 enum GE_RESULT {
     GE_LESS      = -1,
     GE_EQUAL     =  0,

lib/builtins/int_lib.h

 /* Assumption: Right shift of signed negative is arithmetic shift. */
 /* Assumption: Endianness is little or big (not mixed). */
 
+#define FNALIAS(alias_name, original_name)         \
+  void alias_name() __attribute__((alias(#original_name)))
+
 /* ABI macro definitions */
 
 #if __ARM_EABI__