Page MenuHomePhabricator

jmgao (Josh Gao)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2015, 1:31 PM (235 w, 4 d)

Recent Activity

Sep 10 2018

jmgao added inline comments to D51901: Thread Safety Analysis: warnings for attributes without arguments.
Sep 10 2018, 6:52 PM

Aug 11 2017

jmgao added a reverting change for rL310403: Thread Safety Analysis: warn on nonsensical attributes.: rL310698: Revert "Thread Safety Analysis: warn on nonsensical attributes.".
Aug 11 2017, 12:55 AM
jmgao committed rL310698: Revert "Thread Safety Analysis: warn on nonsensical attributes.".
Revert "Thread Safety Analysis: warn on nonsensical attributes."
Aug 11 2017, 12:55 AM

Aug 8 2017

jmgao added a comment to D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.

Thanks for the review!

Aug 8 2017, 12:48 PM
jmgao committed rL310402: Reland "Thread Safety Analysis: fix assert_capability.".
Reland "Thread Safety Analysis: fix assert_capability."
Aug 8 2017, 12:45 PM
jmgao committed rL310403: Thread Safety Analysis: warn on nonsensical attributes..
Thread Safety Analysis: warn on nonsensical attributes.
Aug 8 2017, 12:45 PM
jmgao closed D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings by committing rL310403: Thread Safety Analysis: warn on nonsensical attributes..
Aug 8 2017, 12:45 PM
jmgao closed D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings by committing rL310402: Reland "Thread Safety Analysis: fix assert_capability.".
Aug 8 2017, 12:45 PM

Aug 7 2017

jmgao updated the diff for D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.

Reword warnings.

Aug 7 2017, 12:27 PM

Aug 2 2017

jmgao updated the diff for D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.

Fix commit messages.

Aug 2 2017, 1:30 PM
jmgao updated the diff for D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.

Remove accidental trailing backslash.

Aug 2 2017, 1:28 PM
jmgao updated subscribers of D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.
Aug 2 2017, 1:26 PM
jmgao updated the summary of D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.
Aug 2 2017, 1:26 PM
jmgao created D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings.
Aug 2 2017, 1:25 PM

Aug 1 2017

jmgao committed rL309731: Revert "Thread Safety Analysis: fix assert_capability.".
Revert "Thread Safety Analysis: fix assert_capability."
Aug 1 2017, 12:54 PM
jmgao added a reverting change for rL309725: Thread Safety Analysis: fix assert_capability.: rL309731: Revert "Thread Safety Analysis: fix assert_capability.".
Aug 1 2017, 12:54 PM
jmgao abandoned D36169: Thread Safety Analysis: fix broken test..
Aug 1 2017, 12:53 PM
jmgao created D36169: Thread Safety Analysis: fix broken test..
Aug 1 2017, 12:43 PM
jmgao closed D36122: Thread Safety Analysis: fix assert_capability. by committing rL309725: Thread Safety Analysis: fix assert_capability..
Aug 1 2017, 12:20 PM
jmgao committed rL309725: Thread Safety Analysis: fix assert_capability..
Thread Safety Analysis: fix assert_capability.
Aug 1 2017, 12:19 PM

Jul 31 2017

jmgao added reviewers for D36122: Thread Safety Analysis: fix assert_capability.: delesley, rnk.
Jul 31 2017, 4:37 PM
jmgao created D36122: Thread Safety Analysis: fix assert_capability..
Jul 31 2017, 4:36 PM

Jun 10 2016

jmgao committed rL272413: Strip Android version when looking up toolchain paths..
Strip Android version when looking up toolchain paths.
Jun 10 2016, 11:37 AM
jmgao closed D21163: Strip Android version when looking up toolchain paths. by committing rL272413: Strip Android version when looking up toolchain paths..
Jun 10 2016, 11:37 AM
jmgao added a comment to D21163: Strip Android version when looking up toolchain paths..

Thanks for the review!

Jun 10 2016, 11:27 AM

Jun 9 2016

jmgao updated the diff for D21163: Strip Android version when looking up toolchain paths..

Add test.

Jun 9 2016, 6:21 PM

Jun 8 2016

jmgao retitled D21163: Strip Android version when looking up toolchain paths. from to Strip Android version when looking up toolchain paths..
Jun 8 2016, 6:16 PM

Aug 27 2015

jmgao added a comment to D12181: [sanitizer] Add -fsanitize-trap-function..

With #1, it seems unfortunate to not be able to distinguish between a sanitize inserted __builtin_trap and code manually calling it. (Would there be an -fsanitize-trap=trap? :-)
With #2, we're worried about the generated code being noticeably worse in the unexceptional case than running without the sanitizers.

Aug 27 2015, 6:53 PM
jmgao added a comment to D12181: [sanitizer] Add -fsanitize-trap-function..

Ping, I think @samsonov was waiting on @rsmith's feedback on the following:

Aug 27 2015, 3:03 PM

Aug 21 2015

jmgao added a comment to D12181: [sanitizer] Add -fsanitize-trap-function..
Aug 21 2015, 9:35 AM
jmgao added inline comments to D12181: [sanitizer] Add -fsanitize-trap-function..
Aug 21 2015, 9:34 AM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Remove more \briefs

Aug 21 2015, 9:29 AM

Aug 20 2015

jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

clang-format, remove \brief from modified doxygen comments.

Aug 20 2015, 8:02 PM
jmgao committed rL245663: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
[compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2.
Aug 20 2015, 7:52 PM
jmgao closed D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2. by committing rL245663: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
Aug 20 2015, 7:52 PM
jmgao committed rL245648: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}.
Aug 20 2015, 5:26 PM
jmgao closed D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}. by committing rL245648: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 20 2015, 5:26 PM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Make methods private

Aug 20 2015, 5:19 PM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Doc fix, 80 col

Aug 20 2015, 4:47 PM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Make option fit in 80 cols

Aug 20 2015, 4:45 PM
jmgao added a comment to D12181: [sanitizer] Add -fsanitize-trap-function..

Can you please give a brief description of the motivation for this change? When would it be appropriate to use this rather than -ftrap-function?

I'd still like an answer to this. It's not clear to me what the purpose of this is, and why you'd want a custom runtime hook for sanitizer traps but not other traps. The only time we emit a trap using -ftrap-function where there is no corresponding sanitizer is for __builtin_trap(); is the intention that you still want a normal trap for that builtin?

Aug 20 2015, 4:29 PM
jmgao updated the diff for D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..

Use DEFINE_COMPILERRT_PRIVATE_FUNCTION in call_apsr.S, file headers.

Aug 20 2015, 4:04 PM
jmgao added inline comments to D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
Aug 20 2015, 3:32 PM
jmgao added a comment to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..

Please use the DEFINE_COMPILERRT_PRIVATE_FUNCTION macros for call_apr_{d,f}.

Aug 20 2015, 3:26 PM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Improve comment

Aug 20 2015, 2:59 PM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Address comments

Aug 20 2015, 2:56 PM
jmgao added inline comments to D12181: [sanitizer] Add -fsanitize-trap-function..
Aug 20 2015, 2:50 PM
jmgao updated the diff for D12181: [sanitizer] Add -fsanitize-trap-function..

Uploading diff with arcanist.

Aug 20 2015, 1:40 PM
jmgao added inline comments to D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
Aug 20 2015, 10:58 AM

Aug 19 2015

jmgao updated subscribers of D12181: [sanitizer] Add -fsanitize-trap-function..
Aug 19 2015, 6:24 PM
jmgao added inline comments to D12181: [sanitizer] Add -fsanitize-trap-function..
Aug 19 2015, 6:24 PM
jmgao retitled D12181: [sanitizer] Add -fsanitize-trap-function. from to [sanitizer] Add -fsanitize-trap-function..
Aug 19 2015, 6:23 PM
jmgao added inline comments to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 19 2015, 11:27 AM
jmgao updated the diff for D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 19 2015, 11:26 AM
jmgao added inline comments to D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
Aug 19 2015, 10:43 AM
jmgao updated the diff for D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
Aug 19 2015, 10:43 AM

Aug 18 2015

jmgao added inline comments to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 18 2015, 9:38 PM
jmgao added inline comments to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 18 2015, 5:42 PM
jmgao added inline comments to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 18 2015, 4:28 PM
jmgao updated the diff for D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..

Address most of the comments

Aug 18 2015, 4:28 PM
jmgao updated the diff for D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..

Add and use an FNALIAS macro

Aug 18 2015, 2:11 PM
jmgao added a comment to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..

Also, avoid using push lr / pop pc, since this behaviour doesn't work across all ARM cores. There's a macro for returning that should be used.

Aug 18 2015, 1:52 PM
jmgao added a comment to D12088: Implement __aeabi_{f,d}rsub..

Do we need to do anything for make?

Aug 18 2015, 10:58 AM
jmgao updated the diff for D12088: Implement __aeabi_{f,d}rsub..

Added new files to CMakeLists.txt

Aug 18 2015, 10:56 AM
jmgao added inline comments to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 18 2015, 10:14 AM
jmgao added a comment to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..

Oops, I somehow managed to overlook the Done checkbox in Phabricator.

Aug 18 2015, 10:10 AM
jmgao added a comment to D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..

Thanks for the comments, I'll fix them up and have an updated patch shortly

Aug 18 2015, 10:08 AM

Aug 17 2015

jmgao added a comment to D12088: Implement __aeabi_{f,d}rsub..

Is there a reason to not add them to the files where the FIXME were?

Aug 17 2015, 6:46 PM
jmgao retitled D12091: [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2. from to [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
Aug 17 2015, 3:45 PM
jmgao retitled D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}. from to Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}..
Aug 17 2015, 2:04 PM
jmgao retitled D12088: Implement __aeabi_{f,d}rsub. from to Implement __aeabi_{f,d}rsub..
Aug 17 2015, 1:59 PM