This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2.
ClosedPublic

Authored by jmgao on Aug 17 2015, 3:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jmgao updated this revision to Diff 32348.Aug 17 2015, 3:45 PM
jmgao retitled this revision from to [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2..
jmgao updated this object.
jmgao added a reviewer: compnerd.
jmgao set the repository for this revision to rL LLVM.
jmgao added a subscriber: llvm-commits.
compnerd edited edge metadata.Aug 17 2015, 7:53 PM

Can you define an use a macro similar to ARM_EABI_FNALIAS in int_lib.h please?

jmgao updated this revision to Diff 32450.Aug 18 2015, 2:11 PM
jmgao edited edge metadata.
jmgao removed rL LLVM as the repository for this revision.

Add and use an FNALIAS macro

compnerd accepted this revision.Aug 18 2015, 7:53 PM
compnerd edited edge metadata.
compnerd added inline comments.
lib/builtins/comparedf2.c
83

Use /* */, since I don't believe we are forcing C99. Similar throughout.

lib/builtins/int_lib.h
23 ↗(On Diff #32450)

clang-format this line please.

This revision is now accepted and ready to land.Aug 18 2015, 7:53 PM
jmgao updated this revision to Diff 32575.Aug 19 2015, 10:43 AM
jmgao edited edge metadata.
jmgao marked an inline comment as done.
jmgao added inline comments.
lib/builtins/comparedf2.c
83

These files only have // comments, and there are a bunch of other ones that are similar.

compnerd added inline comments.Aug 19 2015, 8:57 PM
lib/builtins/comparedf2.c
83

Okay, seems fair enough

asl added a subscriber: asl.Aug 20 2015, 12:31 AM
asl added inline comments.
lib/builtins/int_lib.h
23 ↗(On Diff #32575)

What's in darwin case? Shall we define these aliases there as well?

jmgao added inline comments.Aug 20 2015, 10:58 AM
lib/builtins/int_lib.h
23 ↗(On Diff #32575)

This will be defined for everything that includes int_lib.h

jmgao marked an inline comment as done.Aug 20 2015, 3:32 PM
jmgao added inline comments.
lib/builtins/int_lib.h
23 ↗(On Diff #32575)

Sorry, misread your comment. I'm not sure what should happen in darwin.

This revision was automatically updated to reflect the committed changes.
jmgao marked an inline comment as done.
compnerd added inline comments.Aug 20 2015, 8:39 PM
lib/builtins/int_lib.h
23 ↗(On Diff #32575)

Darwin did at one point use libgcc, so I don't think that this would be problematic. Do you have some reason to believe it would be? We could easily conditionalise the aliases if that is the case.