Reverse the order of modules-loaded/unloaded & breakpoint-changed events

[jingham]

Summary

Currently, when a new module is loaded/unloaded and it causes new breakpoint locations to be created or resolved, you get two events, an modules-loaded event and a breakpoint-changed event. But they come out in the order:

breakpoint-changed
modules-loaded

which doesn't make much sense. This patch reverses the order.

This should be uncontroversial, but I put the patch up to check that vscode or other clients haven't coded around this odd behavior.

[clayborg]

lldb-vscode will be just fine.

lldb/source/Target/Target.cpp

if (m_valid && module_list.GetSize()) {
     BroadcastEvent(eBroadcastBitSymbolsLoaded,
                    new TargetEventData(this->shared_from_this(), module_list));
   }
 }
 
 void Target::ModulesDidUnload(ModuleList &module_list, bool delete_locations) {
   if (m_valid && module_list.GetSize()) {
     UnloadModuleSections(module_list);
+    BroadcastEvent(eBroadcastBitModulesUnloaded,
+                   new TargetEventData(this->shared_from_this(), module_list));
     m_breakpoint_list.UpdateBreakpoints(module_list, false, delete_locations);
     m_internal_breakpoint_list.UpdateBreakpoints(module_list, false,
                                                  delete_locations);
-    BroadcastEvent(eBroadcastBitModulesUnloaded,
-                   new TargetEventData(this->shared_from_this(), module_list));
   }
 }
 
 bool Target::ModuleIsExcludedForUnconstrainedSearches(
     const FileSpec &module_file_spec) {
   if (GetBreakpointsConsultPlatformAvoidList()) {
     ModuleList matchingModules;
     ModuleSpec module_spec(module_file_spec);