This is an archive of the discontinued LLVM Phabricator instance.

[Openmp]: Missing import statement in openmp interface for Fortran
ClosedPublic

Authored by malharJ on Mar 1 2022, 2:54 AM.

Details

Summary

The extra import is required to access entities in host scoping unit.
Also looks like it's present in the other interface functions as well.

Diff Detail

Event Timeline

malharJ created this revision.Mar 1 2022, 2:54 AM
malharJ requested review of this revision.Mar 1 2022, 2:54 AM
Herald added a project: Restricted Project. · View Herald Transcript
pawelo12345678 accepted this revision.Mar 1 2022, 3:37 AM

I like it.

This revision is now accepted and ready to land.Mar 1 2022, 3:37 AM

Then the "use omp_lib_kinds" lines can be removed, as they supposed to make
the omp_allocator_handle_kind visible in the interfaces, but probably do not work for all compilers
(or when omp* modules were not built or not accessible).

These were copy-paste errors transferred from omp_lib.f90.var file where omp* modules are defined.
Thanks for taking care of this.

malharJ updated this revision to Diff 412124.EditedMar 1 2022, 8:53 AM
  • removed usage of "use omp_lib_kinds" statement as the "import" is sufficient and consistent.
AndreyChurbanov accepted this revision.Mar 1 2022, 9:18 AM

LG to me as well.
Thanks.