Page MenuHomePhabricator

malharJ (Malhar)
Malhar

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2021, 9:48 PM (45 w, 6 d)

Recent Activity

Tue, Nov 23

malharJ added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

ping,

Tue, Nov 23, 2:32 AM · Restricted Project

Sun, Nov 14

malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Sun, Nov 14, 7:45 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  • Rebased patch onto main
  • Updated code to avoid printing <unknown> when no debug info is present
  • minor formatting updates
Sun, Nov 14, 7:44 AM · Restricted Project

Thu, Nov 4

malharJ added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

@sdesmalen , can you please review the latest updates ?

Thu, Nov 4, 3:59 AM · Restricted Project

Tue, Nov 2

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Fixed minor typos and one LIT test.

Tue, Nov 2, 4:10 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  • Removed remark emission (OptimizationRemarkEmitter) to outside LoopAccessAnalysis. LAA generates a "Report" which can be used by other passes to emit remarks.i
Tue, Nov 2, 3:08 AM · Restricted Project

Nov 1 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  • Removed the mechanism that collected the remarks (enum "FailureReason" and function "elaborateMemoryReport()") and emitted them at the end.
Nov 1 2021, 11:13 AM · Restricted Project

Oct 21 2021

malharJ added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Are there any further review comments ?

Oct 21 2021, 10:02 AM · Restricted Project

Oct 19 2021

malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Oct 19 2021, 2:39 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  1. Updated format of remark
  2. Removed pointers from UncomputablePtrs Set if it's bound can be computed on a retry (with Assumptions).
Oct 19 2021, 2:38 AM · Restricted Project

Sep 10 2021

malharJ added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Are there any other review comments ?

Sep 10 2021, 9:02 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

minor formatting update for fixing a failing test.

Sep 10 2021, 1:49 AM · Restricted Project

Sep 9 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

corrected trivial typo in LIT test.

Sep 9 2021, 4:59 PM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Sep 9 2021, 9:14 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  • Updated remark for unknown array bounds case
Sep 9 2021, 9:13 AM · Restricted Project

Sep 8 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Trivial formatting update.

Sep 8 2021, 9:28 AM · Restricted Project

Sep 7 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Re-added the remark/note about using pragma loop distribute.

Sep 7 2021, 6:19 AM · Restricted Project

Sep 6 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

This is to correct a mistake made in the previous patch.

Sep 6 2021, 11:08 PM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Sep 6 2021, 7:27 PM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  1. Fixed the unit tests:
Sep 6 2021, 7:25 PM · Restricted Project

Sep 3 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  • Moved remark generating function (elaborateMemoryReport()) and some related functions from LoopVectorizationLegality to the class LoopAccessInfo (inside the file LoopAccessAnalysis).
Sep 3 2021, 1:59 PM · Restricted Project
malharJ added inline comments to D108763: Use type sizes when determining dependence.
Sep 3 2021, 9:20 AM · Restricted Project

Sep 1 2021

malharJ added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

@fhahn , but these remarks are specific to vectorization (ie. scenarios where loop does not get vectorized) ...
are there any passes (other than LV) which would require this information ?

Sep 1 2021, 5:58 AM · Restricted Project

Aug 31 2021

malharJ added inline comments to D108763: Use type sizes when determining dependence.
Aug 31 2021, 6:54 AM · Restricted Project
malharJ added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

(Can someone else please review the patch as well ?)

Aug 31 2021, 12:15 AM · Restricted Project

Aug 24 2021

malharJ added reviewers for D108371: [LAA] Add Memory dependence and unknown bounds remarks.: fhahn, RKSimon.
Aug 24 2021, 8:25 AM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Aug 24 2021, 8:22 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  1. Added a standardized method of outputting the debug location.

Also changed the output format accordingly.

Aug 24 2021, 8:21 AM · Restricted Project

Aug 22 2021

malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Aug 22 2021, 4:57 PM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Aug 22 2021, 4:56 PM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Removed the following:

  • Most Module flags metadata (llvm.module.flags)
  • function attributes
  • llvm.dbg.value intrinsics and its associated metadata
  • all DILocation nodes (and their usage) that did not result in the remark being generated.
Aug 22 2021, 4:55 PM · Restricted Project

Aug 20 2021

malharJ updated the summary of D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Aug 20 2021, 2:25 AM · Restricted Project

Aug 19 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence and unknown bounds remarks..
  1. Updated failing test.
  2. Also made minor formatting changes to variable names.
Aug 19 2021, 12:04 PM · Restricted Project
malharJ added reviewers for D108371: [LAA] Add Memory dependence and unknown bounds remarks.: jdoerfert, mkuper.
Aug 19 2021, 6:48 AM · Restricted Project
malharJ requested review of D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Aug 19 2021, 6:11 AM · Restricted Project
malharJ updated malharJ.
Aug 19 2021, 5:36 AM

May 17 2021

malharJ added inline comments to D102629: [ARM] Fix inline memcpy trip count sequence.
May 17 2021, 4:26 PM · Restricted Project
malharJ accepted D102629: [ARM] Fix inline memcpy trip count sequence.

Thanks for spotting and correcting this @dmgreen,

May 17 2021, 1:48 PM · Restricted Project

May 14 2021

malharJ added inline comments to D102269: [ARM] Expand predecessor search to multiple blocks when reverting WhileLoopStarts.
May 14 2021, 1:10 AM · Restricted Project

May 13 2021

malharJ added inline comments to D102269: [ARM] Expand predecessor search to multiple blocks when reverting WhileLoopStarts.
May 13 2021, 6:07 AM · Restricted Project

May 7 2021

malharJ committed rGdfe3ffaa4a47: [ARM] Transforming memset to Tail predicated Loop (authored by malharJ).
[ARM] Transforming memset to Tail predicated Loop
May 7 2021, 5:36 AM
malharJ closed D100435: [ARM] Transforming memset to Tail predicated Loop.
May 7 2021, 5:36 AM · Restricted Project

May 6 2021

malharJ committed rG9ff38e2d9dd7: [ARM] Transforming memcpy to Tail predicated Loop (authored by malharJ).
[ARM] Transforming memcpy to Tail predicated Loop
May 6 2021, 3:27 PM
malharJ closed D99723: [ARM] Transforming memcpy to Tail predicated Loop.
May 6 2021, 3:26 PM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Fix for MachineVerifier error during Buildbot failure
https://lab.llvm.org/buildbot/#/builders/16/builds/10462

May 6 2021, 5:06 AM · Restricted Project
malharJ reopened D99723: [ARM] Transforming memcpy to Tail predicated Loop.
May 6 2021, 4:58 AM · Restricted Project
malharJ added a reverting change for rGb856f4a232cb: [ARM] Transforming memcpy to Tail predicated Loop: rGfc690777fce0: Revert "[ARM] Transforming memcpy to Tail predicated Loop".
May 6 2021, 4:43 AM
malharJ committed rGfc690777fce0: Revert "[ARM] Transforming memcpy to Tail predicated Loop" (authored by malharJ).
Revert "[ARM] Transforming memcpy to Tail predicated Loop"
May 6 2021, 4:43 AM
malharJ added a reverting change for D99723: [ARM] Transforming memcpy to Tail predicated Loop: rGfc690777fce0: Revert "[ARM] Transforming memcpy to Tail predicated Loop".
May 6 2021, 4:42 AM · Restricted Project
malharJ added a comment to D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Thanks a lot for the review !

May 6 2021, 1:41 AM · Restricted Project
malharJ committed rGb856f4a232cb: [ARM] Transforming memcpy to Tail predicated Loop (authored by malharJ).
[ARM] Transforming memcpy to Tail predicated Loop
May 6 2021, 1:39 AM
malharJ closed D99723: [ARM] Transforming memcpy to Tail predicated Loop.
May 6 2021, 1:39 AM · Restricted Project

May 5 2021

malharJ committed rG9ba5238c28da: [ARM] Simplification to ARMBlockPlacement Pass. (authored by malharJ).
[ARM] Simplification to ARMBlockPlacement Pass.
May 5 2021, 5:21 PM
malharJ closed D100094: [ARM] Simplification to ARMBlockPlacement Pass..
May 5 2021, 5:20 PM · Restricted Project
malharJ added inline comments to D100435: [ARM] Transforming memset to Tail predicated Loop.
May 5 2021, 12:07 PM · Restricted Project
malharJ updated the diff for D100435: [ARM] Transforming memset to Tail predicated Loop.

Rebased patch to get latest updates to parent patch.

May 5 2021, 12:06 PM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Changed cli option for conversion of memcpy to TP loop to be disabled by default.
The disable may be temporary, and will be removed after some more testing.

May 5 2021, 8:59 AM · Restricted Project

May 4 2021

malharJ updated the diff for D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Minor updates: formatting + test

May 4 2021, 11:20 PM · Restricted Project
malharJ added inline comments to D99723: [ARM] Transforming memcpy to Tail predicated Loop.
May 4 2021, 10:11 PM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Fix for bug spotted by dmgreen (thank you):

May 4 2021, 10:06 PM · Restricted Project
malharJ added inline comments to D100094: [ARM] Simplification to ARMBlockPlacement Pass..
May 4 2021, 12:36 AM · Restricted Project
malharJ updated the diff for D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Updated tests:

  • Added a test that checks if Predecessor is moved backwards if moving it does not convert a forward WLS into backwards WLS.
  • simplified the test file a bit further.
May 4 2021, 12:35 AM · Restricted Project

Apr 29 2021

malharJ retitled D100094: [ARM] Simplification to ARMBlockPlacement Pass. from [ARM] This patch adds some simplifications to ARMBlockPlacement Pass. to [ARM] Simplification to ARMBlockPlacement Pass..
Apr 29 2021, 4:03 AM · Restricted Project
malharJ added a comment to D100094: [ARM] Simplification to ARMBlockPlacement Pass..

@SjoerdMeijer and @dmgreen , I can confirm the performance of downstream tests is unaffected by this patch.

Apr 29 2021, 3:08 AM · Restricted Project
malharJ updated the diff for D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Addressed review comments:

  • Added a test for multiple predecessors.
  • Updated code to renumber all blocks + compute offset of all blocks.
Apr 29 2021, 3:06 AM · Restricted Project

Apr 27 2021

malharJ updated the diff for D100435: [ARM] Transforming memset to Tail predicated Loop.

Rebased on top of latest parent patch to get the fix for clang-format issues.
Minor formatting update.

Apr 27 2021, 10:30 PM · Restricted Project
malharJ added inline comments to D100435: [ARM] Transforming memset to Tail predicated Loop.
Apr 27 2021, 10:32 AM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Rebased patch + minor formatting updates.

Apr 27 2021, 7:04 AM · Restricted Project

Apr 25 2021

malharJ added inline comments to D100435: [ARM] Transforming memset to Tail predicated Loop.
Apr 25 2021, 4:23 PM · Restricted Project
malharJ updated the diff for D100435: [ARM] Transforming memset to Tail predicated Loop.

Minor formatting updates to address review comments.

Apr 25 2021, 4:23 PM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Minor formatting updates.

Apr 25 2021, 10:34 AM · Restricted Project

Apr 23 2021

malharJ added a comment to D100094: [ARM] Simplification to ARMBlockPlacement Pass..

I have run (and it passes)

Apr 23 2021, 2:31 AM · Restricted Project

Apr 21 2021

malharJ added inline comments to D100435: [ARM] Transforming memset to Tail predicated Loop.
Apr 21 2021, 8:38 AM · Restricted Project
malharJ updated the diff for D100435: [ARM] Transforming memset to Tail predicated Loop.

Addressed review comments:

Apr 21 2021, 8:38 AM · Restricted Project

Apr 19 2021

malharJ added a comment to D100094: [ARM] Simplification to ARMBlockPlacement Pass..

ping

Apr 19 2021, 3:37 PM · Restricted Project

Apr 18 2021

malharJ added inline comments to D100435: [ARM] Transforming memset to Tail predicated Loop.
Apr 18 2021, 9:58 AM · Restricted Project
malharJ updated the diff for D100435: [ARM] Transforming memset to Tail predicated Loop.
  • Combined test files of this patch and parent patch (D99723)
  • Corrected some minor formatting errors
Apr 18 2021, 9:43 AM · Restricted Project
malharJ updated the summary of D100435: [ARM] Transforming memset to Tail predicated Loop.
Apr 18 2021, 9:27 AM · Restricted Project
malharJ updated the diff for D100435: [ARM] Transforming memset to Tail predicated Loop.

Moved vdup creation to inside EmitTargetCodeForMemset()

Apr 18 2021, 9:02 AM · Restricted Project

Apr 17 2021

malharJ updated the summary of D99723: [ARM] Transforming memcpy to Tail predicated Loop.
Apr 17 2021, 3:51 PM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Rebased patch and removed the dependency as it has been closed.

Apr 17 2021, 3:49 PM · Restricted Project

Apr 15 2021

malharJ added inline comments to D99723: [ARM] Transforming memcpy to Tail predicated Loop.
Apr 15 2021, 3:08 AM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Addressed review comments:

  • moved cli option (when set) to be of higher priority than optNone/optSize
  • minor formatting updates.
Apr 15 2021, 3:08 AM · Restricted Project
malharJ added inline comments to D99723: [ARM] Transforming memcpy to Tail predicated Loop.
Apr 15 2021, 2:06 AM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Addressed review comments:

  • renamed test files
  • disabled inline memcpy for optimize size cases (-Os, -Oz) and added tests for the same
  • also added tests for constant size inputs to ensure the threshold values are tested as well.
  • minor formatting changes
Apr 15 2021, 2:06 AM · Restricted Project

Apr 14 2021

malharJ updated the diff for D100376: [ARM] Prevent phi-node-elimination from generating copy above t2WhileLoopStartLR.

Simplified the test file.

Apr 14 2021, 10:26 PM · Restricted Project
malharJ accepted D99940: [ARM] Combine sub 0, csinc X, Y, CC -> csinv -X, Y, CC.
Apr 14 2021, 2:30 PM · Restricted Project
malharJ added a comment to D99940: [ARM] Combine sub 0, csinc X, Y, CC -> csinv -X, Y, CC.

Thanks. LGTM

Apr 14 2021, 2:04 PM · Restricted Project
malharJ updated the diff for D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Updated failing tests.

Apr 14 2021, 5:31 AM · Restricted Project

Apr 13 2021

malharJ added a reviewer for D100435: [ARM] Transforming memset to Tail predicated Loop: SjoerdMeijer.
Apr 13 2021, 7:30 PM · Restricted Project
malharJ requested review of D100435: [ARM] Transforming memset to Tail predicated Loop.
Apr 13 2021, 7:16 PM · Restricted Project
malharJ updated the diff for D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Corrected leftover (from the rebase) error in code.

Apr 13 2021, 6:09 AM · Restricted Project
malharJ updated the summary of D100094: [ARM] Simplification to ARMBlockPlacement Pass..
Apr 13 2021, 5:18 AM · Restricted Project
malharJ added a comment to D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Do you think you can review this patch ?
It's not really a priority (but potentially a good simplification), but since you had reviewed the original patch, I thought I'd ask you first.

Apr 13 2021, 5:11 AM · Restricted Project
malharJ added inline comments to D100094: [ARM] Simplification to ARMBlockPlacement Pass..
Apr 13 2021, 5:08 AM · Restricted Project
malharJ updated the diff for D100094: [ARM] Simplification to ARMBlockPlacement Pass..

Rebased the patch on top of main branch to get the changes from D99649

Apr 13 2021, 5:03 AM · Restricted Project
malharJ added inline comments to D99723: [ARM] Transforming memcpy to Tail predicated Loop.
Apr 13 2021, 3:57 AM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Addressed remaining review comments:

  • Separated a change into it's own patch and added as dependency
  • minor formatting updates
  • added a testcase with size of type other than i32
Apr 13 2021, 3:56 AM · Restricted Project
malharJ requested review of D100376: [ARM] Prevent phi-node-elimination from generating copy above t2WhileLoopStartLR.
Apr 13 2021, 3:32 AM · Restricted Project

Apr 9 2021

malharJ added a comment to D99723: [ARM] Transforming memcpy to Tail predicated Loop.

I'm a little worried that WLSTP is going to cause problems ...

Apr 9 2021, 9:24 AM · Restricted Project