Page MenuHomePhabricator

malharJ (Malhar)
Malhar

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2021, 9:48 PM (97 w, 3 d)

Recent Activity

Oct 20 2022

Herald added a project to D97993: [Driver] Suppress GCC detection under -B: Restricted Project.

A couple of things here:

Oct 20 2022, 2:39 AM · Restricted Project, Restricted Project

Oct 19 2022

malharJ committed rGcea951dccd9a: Avoid exporting 80-bit fp functions for architectures other than Intel. (authored by malharJ).
Avoid exporting 80-bit fp functions for architectures other than Intel.
Oct 19 2022, 8:04 AM · Restricted Project, Restricted Project
malharJ closed D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 19 2022, 8:03 AM · Restricted Project, Restricted Project
malharJ updated the summary of D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 19 2022, 3:34 AM · Restricted Project, Restricted Project

Oct 17 2022

malharJ updated the diff for D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
  • replaced %ifndef arch_64, arch_aarch64 with IS_IA_ARCH macro
Oct 17 2022, 4:19 PM · Restricted Project, Restricted Project

Oct 14 2022

malharJ updated the summary of D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 14 2022, 2:55 AM · Restricted Project, Restricted Project
malharJ added inline comments to D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 14 2022, 2:54 AM · Restricted Project, Restricted Project
malharJ updated the diff for D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
  • Added IS_IA_ARCH guard around __kmpc_atomic_float10_*_fp functions
Oct 14 2022, 2:45 AM · Restricted Project, Restricted Project

Oct 12 2022

malharJ added a reviewer for D135795: Avoid exporting 80-bit fp functions for architectures other than Intel.: alvinhochun.
Oct 12 2022, 10:43 AM · Restricted Project, Restricted Project
malharJ updated the summary of D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 12 2022, 10:39 AM · Restricted Project, Restricted Project
malharJ requested review of D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 12 2022, 10:37 AM · Restricted Project, Restricted Project

Jul 22 2022

malharJ committed rG41958f76d8a2: [Costmodel] Add "type-based-intrinsic-cost" cli option (authored by malharJ).
[Costmodel] Add "type-based-intrinsic-cost" cli option
Jul 22 2022, 7:51 AM · Restricted Project, Restricted Project
malharJ closed D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 22 2022, 7:51 AM · Restricted Project, Restricted Project
malharJ added a comment to D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.

ping

Jul 22 2022, 2:44 AM · Restricted Project, Restricted Project

Jul 18 2022

malharJ updated the diff for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
  • removed blank line
Jul 18 2022, 8:26 AM · Restricted Project, Restricted Project
malharJ updated the summary of D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 18 2022, 8:08 AM · Restricted Project, Restricted Project
malharJ updated the diff for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
  • Removed the SVE gather/scatter case as per review comment
Jul 18 2022, 8:04 AM · Restricted Project, Restricted Project

Jul 12 2022

malharJ updated the summary of D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 12 2022, 1:49 AM · Restricted Project, Restricted Project
malharJ retitled D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option from [Costmodel] Add type based costmodel analysis for masked scatter/gather intrinsics to [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 12 2022, 1:49 AM · Restricted Project, Restricted Project

Jul 11 2022

malharJ added a comment to D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.

ping

Jul 11 2022, 10:38 AM · Restricted Project, Restricted Project

Jul 6 2022

malharJ added inline comments to D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 6 2022, 6:10 AM · Restricted Project, Restricted Project
malharJ updated the diff for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
  • Addressed minor formatting issues
Jul 6 2022, 6:09 AM · Restricted Project, Restricted Project

Jul 5 2022

malharJ updated the diff for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
  • Updated LIT test
  • minor formatting updates
Jul 5 2022, 11:27 AM · Restricted Project, Restricted Project
malharJ added reviewers for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option: huntergr, paulwalker-arm.
Jul 5 2022, 10:04 AM · Restricted Project, Restricted Project
malharJ updated the diff for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
  • Added updates when printing instruction cost using new pass manager.
Jul 5 2022, 6:45 AM · Restricted Project, Restricted Project
malharJ requested review of D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 5 2022, 1:17 AM · Restricted Project, Restricted Project

Jun 17 2022

malharJ added inline comments to D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.
Jun 17 2022, 7:13 AM · Restricted Project, Restricted Project
malharJ committed rG6bb40552f235: [LoopVectorize] Add support for invariant stores of ordered reductions (authored by malharJ).
[LoopVectorize] Add support for invariant stores of ordered reductions
Jun 17 2022, 6:56 AM · Restricted Project, Restricted Project
malharJ closed D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.
Jun 17 2022, 6:56 AM · Restricted Project, Restricted Project
malharJ committed rGc80c57674e4d: [Clang] Allow 'Complex float __attribute__((mode(HC)))' (authored by jolanta.jensen).
[Clang] Allow 'Complex float __attribute__((mode(HC)))'
Jun 17 2022, 5:01 AM · Restricted Project, Restricted Project
malharJ closed D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Jun 17 2022, 5:01 AM · Restricted Project, Restricted Project
Herald added projects to D51829: [MachineInstr] In addRegisterKilled and addRegisterDead, don't remove operands from inline assembly instructions if they have an associated flag operand.: Restricted Project, Restricted Project.

The added condition

Jun 17 2022, 2:57 AM · Restricted Project, Restricted Project

Jun 10 2022

malharJ added a comment to D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.

ping

Jun 10 2022, 6:48 AM · Restricted Project, Restricted Project

Jun 6 2022

malharJ updated the diff for D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.
  • Updated comment in source
Jun 6 2022, 9:29 AM · Restricted Project, Restricted Project
malharJ updated the diff for D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.
  • Removed redundant blank lines from test
Jun 6 2022, 8:28 AM · Restricted Project, Restricted Project
malharJ updated the diff for D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.
  • Updated LIT test with more detailed CHECKs.

The main difference between this and "fadd_strict" is the presence of
a store (to the invariant destination) in the middle.block

Jun 6 2022, 8:26 AM · Restricted Project, Restricted Project

Jun 1 2022

malharJ requested review of D126772: [LoopVectorize] Add support for invariant stores of ordered reductions.
Jun 1 2022, 4:50 AM · Restricted Project, Restricted Project

Apr 19 2022

malharJ committed rG8daffd1dfb55: Fix SLP score for out of order contiguous loads (authored by alban.bridonneau).
Fix SLP score for out of order contiguous loads
Apr 19 2022, 3:59 AM · Restricted Project, Restricted Project
malharJ closed D123516: Fix SLP score for out of order contiguous loads.
Apr 19 2022, 3:59 AM · Restricted Project, Restricted Project

Apr 11 2022

malharJ added inline comments to D123512: [MachineCombiner]: Avoid including transient instructions in latency calculation.
Apr 11 2022, 11:02 AM · Restricted Project, Restricted Project
malharJ added reviewers for D123512: [MachineCombiner]: Avoid including transient instructions in latency calculation: fhahn, georges.
Apr 11 2022, 7:00 AM · Restricted Project, Restricted Project
malharJ requested review of D123512: [MachineCombiner]: Avoid including transient instructions in latency calculation.
Apr 11 2022, 6:59 AM · Restricted Project, Restricted Project

Mar 16 2022

malharJ added inline comments to D121452: [VPlan] Avoid scalarization for scalable vectors..
Mar 16 2022, 9:34 AM · Restricted Project, Restricted Project
malharJ committed rGa36d269658df: [VPlan] Avoid collecting scalars for SVE (authored by malharJ).
[VPlan] Avoid collecting scalars for SVE
Mar 16 2022, 9:34 AM · Restricted Project
malharJ closed D121452: [VPlan] Avoid scalarization for scalable vectors..
Mar 16 2022, 9:34 AM · Restricted Project, Restricted Project
malharJ updated the diff for D121452: [VPlan] Avoid scalarization for scalable vectors..
  • addressed review comments to reduce size of test output
Mar 16 2022, 6:49 AM · Restricted Project, Restricted Project

Mar 14 2022

malharJ updated the diff for D121452: [VPlan] Avoid scalarization for scalable vectors..
  • Updated LIT test to use autogenerated CHECKs using update_test_checks.py
Mar 14 2022, 3:55 PM · Restricted Project, Restricted Project

Mar 11 2022

malharJ added inline comments to D121452: [VPlan] Avoid scalarization for scalable vectors..
Mar 11 2022, 3:56 AM · Restricted Project, Restricted Project
malharJ retitled D121452: [VPlan] Avoid scalarization for scalable vectors. from [VPlan] Avoid collecting scalars for SVE to [VPlan] Avoid scalarization for scalable vectors..
Mar 11 2022, 3:44 AM · Restricted Project, Restricted Project
malharJ updated the summary of D121452: [VPlan] Avoid scalarization for scalable vectors..
Mar 11 2022, 3:44 AM · Restricted Project, Restricted Project
malharJ retitled D121452: [VPlan] Avoid scalarization for scalable vectors. from [SVE][VPlan] Avoid collecting scalars for SVE to [VPlan] Avoid collecting scalars for SVE.
Mar 11 2022, 3:43 AM · Restricted Project, Restricted Project
malharJ updated the diff for D121452: [VPlan] Avoid scalarization for scalable vectors..
  • Updated terminology to use scalable vectors instead of SVE
Mar 11 2022, 3:42 AM · Restricted Project, Restricted Project
malharJ requested review of D121452: [VPlan] Avoid scalarization for scalable vectors..
Mar 11 2022, 2:00 AM · Restricted Project, Restricted Project

Mar 1 2022

malharJ committed rG6d658f37a4ba: [Openmp]: Missing import statement in openmp interface for Fortran (authored by malharJ).
[Openmp]: Missing import statement in openmp interface for Fortran
Mar 1 2022, 9:37 AM
malharJ closed D120707: [Openmp]: Missing import statement in openmp interface for Fortran.
Mar 1 2022, 9:37 AM · Restricted Project
malharJ updated the diff for D120707: [Openmp]: Missing import statement in openmp interface for Fortran.
  • removed usage of "use omp_lib_kinds" statement as the "import" is sufficient and consistent.
Mar 1 2022, 8:53 AM · Restricted Project
malharJ added a reviewer for D120707: [Openmp]: Missing import statement in openmp interface for Fortran: pawelo12345678.
Mar 1 2022, 3:14 AM · Restricted Project
malharJ requested review of D120707: [Openmp]: Missing import statement in openmp interface for Fortran.
Mar 1 2022, 2:54 AM · Restricted Project

Feb 23 2022

malharJ added a comment to D115873: [LAA] Add remarks for unbounded array access.

Thanks a lot for the review !

Feb 23 2022, 8:07 AM · Restricted Project
malharJ committed rG9f1c6fbf11f5: [LAA] Add remarks for unbounded array access (authored by malharJ).
[LAA] Add remarks for unbounded array access
Feb 23 2022, 7:58 AM
malharJ closed D115873: [LAA] Add remarks for unbounded array access.
Feb 23 2022, 7:58 AM · Restricted Project
malharJ added a comment to D115873: [LAA] Add remarks for unbounded array access.

ping.

Feb 23 2022, 2:27 AM · Restricted Project

Feb 16 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • updated to pass uncomputableptr to recordAnalysis()
Feb 16 2022, 3:10 AM · Restricted Project

Feb 3 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • call recordAnalysis unconditionally.
Feb 3 2022, 2:41 AM · Restricted Project

Feb 2 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • removed conditional write of UncomputablePtr
Feb 2 2022, 11:06 AM · Restricted Project
malharJ committed rG778b455dd660: [LAA] Add Memory dependence remarks. (authored by malharJ).
[LAA] Add Memory dependence remarks.
Feb 2 2022, 4:08 AM
malharJ closed D108371: [LAA] Add Memory dependence remarks..
Feb 2 2022, 4:08 AM · Restricted Project

Jan 31 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • trivial (clang) formatting updates
Jan 31 2022, 1:40 AM · Restricted Project

Jan 28 2022

malharJ updated the diff for D108371: [LAA] Add Memory dependence remarks..
  • minor update to commit message to trigger phabricator builds.
Jan 28 2022, 6:29 AM · Restricted Project
malharJ added inline comments to D115873: [LAA] Add remarks for unbounded array access.
Jan 28 2022, 6:23 AM · Restricted Project
malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Changed UncomputablePtr parameter to be a reference to a pointer.
Jan 28 2022, 5:32 AM · Restricted Project
malharJ added inline comments to D115873: [LAA] Add remarks for unbounded array access.
Jan 28 2022, 3:17 AM · Restricted Project

Jan 27 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Minor update to unit test.
Jan 27 2022, 3:06 PM · Restricted Project
malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Rebased patch onto parent.
Jan 27 2022, 3:01 PM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence remarks..
Jan 27 2022, 2:39 PM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence remarks..
  • Rebased patch.
  • Addressed review comments.
Jan 27 2022, 2:38 PM · Restricted Project
malharJ committed rGb75bdff4a0e9: Trivial update for debug location in LIT test. (authored by malharJ).
Trivial update for debug location in LIT test.
Jan 27 2022, 11:13 AM

Jan 26 2022

malharJ added a comment to D89050: Add support for !noundef metatdata on loads.

Right, but the absence of select -> and/or folding by itself shouldn't matter -- it's only relevant in that it can prevent other transforms

Jan 26 2022, 9:02 AM · Restricted Project
malharJ added a comment to D89050: Add support for !noundef metatdata on loads.

I think most loads in C/C++ can be annotated with !noundef based on language semantics, but I don't think anyone has looked into the necessary clang frontend work yet

Jan 26 2022, 8:07 AM · Restricted Project
malharJ added a comment to D89050: Add support for !noundef metatdata on loads.

Hi everyone,

Jan 26 2022, 6:53 AM · Restricted Project

Jan 22 2022

malharJ committed rGc1988dbf2d19: [openmp] Allow x87 fp functions only in Openmp runtime for x86. (authored by malharJ).
[openmp] Allow x87 fp functions only in Openmp runtime for x86.
Jan 22 2022, 3:33 PM
malharJ closed D117473: [openmp] Allow x87 fp functions only in Openmp runtime for x86..
Jan 22 2022, 3:33 PM · Restricted Project, Restricted Project

Jan 20 2022

malharJ added a reviewer for D117473: [openmp] Allow x87 fp functions only in Openmp runtime for x86.: jlpeyton.
Jan 20 2022, 1:51 AM · Restricted Project, Restricted Project
malharJ added a reviewer for D117473: [openmp] Allow x87 fp functions only in Openmp runtime for x86.: AndreyChurbanov.
Jan 20 2022, 1:41 AM · Restricted Project, Restricted Project

Jan 17 2022

malharJ updated the summary of D117473: [openmp] Allow x87 fp functions only in Openmp runtime for x86..
Jan 17 2022, 6:11 AM · Restricted Project, Restricted Project
malharJ requested review of D117473: [openmp] Allow x87 fp functions only in Openmp runtime for x86..
Jan 17 2022, 6:09 AM · Restricted Project, Restricted Project

Jan 14 2022

malharJ added a comment to D108371: [LAA] Add Memory dependence remarks..

ping.

Jan 14 2022, 2:48 AM · Restricted Project

Jan 5 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Added YAML to LIT test

(This is in response to https://reviews.llvm.org/D108371#inline-1112148)

Jan 5 2022, 6:21 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence remarks..
  • Added YAML to the LIT test
Jan 5 2022, 6:09 AM · Restricted Project

Jan 1 2022

malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Rebased patch to acquire changes from D108371
  • minor updates in the lit test
Jan 1 2022, 5:38 AM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence remarks..
Jan 1 2022, 4:55 AM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence remarks..
  • minor formatting updates
  • moved remark emission code for unsafe mem dependences into a function
  • got rid of some more debuginfo in the LIT test.
Jan 1 2022, 4:54 AM · Restricted Project

Dec 25 2021

malharJ added inline comments to D115873: [LAA] Add remarks for unbounded array access.
Dec 25 2021, 9:52 AM · Restricted Project
malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Updated unit test again (had missed something earlier)
Dec 25 2021, 9:48 AM · Restricted Project
malharJ updated the diff for D115873: [LAA] Add remarks for unbounded array access.
  • Updated unit test
  • Updated minor clang-formatting errors.
Dec 25 2021, 8:17 AM · Restricted Project

Dec 16 2021

malharJ updated the diff for D108371: [LAA] Add Memory dependence remarks..
  • Updated unit test
Dec 16 2021, 2:24 PM · Restricted Project
malharJ updated the diff for D108371: [LAA] Add Memory dependence remarks..
  • rebased patch
Dec 16 2021, 6:42 AM · Restricted Project
malharJ added inline comments to D108371: [LAA] Add Memory dependence remarks..
Dec 16 2021, 5:19 AM · Restricted Project
malharJ requested review of D115873: [LAA] Add remarks for unbounded array access.
Dec 16 2021, 5:15 AM · Restricted Project
malharJ retitled D108371: [LAA] Add Memory dependence remarks. from [LAA] Add Memory dependence and unknown bounds remarks. to [LAA] Add Memory dependence remarks..
Dec 16 2021, 4:58 AM · Restricted Project