This is an archive of the discontinued LLVM Phabricator instance.

Differential D120646

[clang][scan-build] Change mode of installation for scan-build.1
ClosedPublic

Authored by manas on Feb 28 2022, 12:13 AM.

Download Raw Diff

Details

Reviewers

steakhal

Commits

rG3ca109855709: [clang][scan-build] Change mode of installation for scan-build.1

Summary

Currently, manpage for scan-build is installed as a program, with
permission of 755. This patch makes installation of scan-build.1 as
file, with 644 permission.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

manas created this revision.Feb 28 2022, 12:13 AM

Herald added a subscriber: mgorny. · View Herald TranscriptFeb 28 2022, 12:13 AM

manas requested review of this revision.Feb 28 2022, 12:13 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2022, 12:13 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

This patch fixes #53967.

Oh, that's unfortunate.
Thanks for fixing it.

This revision is now accepted and ready to land.Feb 28 2022, 12:32 AM

Harbormaster completed remote builds in B151714: Diff 411745.Feb 28 2022, 12:49 AM

Rebase

I rebased to see if it satisfies the buildbot.

Harbormaster completed remote builds in B151967: Diff 412112.Mar 1 2022, 9:03 AM

Buildbots are happy. I think we can land this. @steakhal do you mind landing it?

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2022, 4:04 AM

Closed by commit rG3ca109855709: [clang][scan-build] Change mode of installation for scan-build.1 (authored by manas, committed by steakhal). · Explain WhyMar 2 2022, 4:12 AM

This revision was automatically updated to reflect the committed changes.

steakhal added a commit: rG3ca109855709: [clang][scan-build] Change mode of installation for scan-build.1.

Revision Contents

Path

Size

clang/

tools/

scan-build/

CMakeLists.txt

2 lines

Diff 412375

clang/tools/scan-build/CMakeLists.txt

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines	foreach(ManPage ${ManPages})
add_custom_command(OUTPUT "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1/${ManPage}"		add_custom_command(OUTPUT "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1/${ManPage}"
COMMAND ${CMAKE_COMMAND} -E make_directory		COMMAND ${CMAKE_COMMAND} -E make_directory
"${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1"		"${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1"
COMMAND ${CMAKE_COMMAND} -E copy		COMMAND ${CMAKE_COMMAND} -E copy
"${CMAKE_CURRENT_SOURCE_DIR}/man/${ManPage}"		"${CMAKE_CURRENT_SOURCE_DIR}/man/${ManPage}"
"${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1/"		"${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1/"
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/man/${ManPage})		DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/man/${ManPage})
list(APPEND Depends "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1/${ManPage}")		list(APPEND Depends "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_MANDIR}/man1/${ManPage}")
install(PROGRAMS man/${ManPage}		install(FILES man/${ManPage}
DESTINATION "${CMAKE_INSTALL_MANDIR}/man1"		DESTINATION "${CMAKE_INSTALL_MANDIR}/man1"
COMPONENT scan-build)		COMPONENT scan-build)
endforeach()		endforeach()

foreach(ShareFile ${ShareFiles})		foreach(ShareFile ${ShareFiles})
add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/share/scan-build/${ShareFile}		add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/share/scan-build/${ShareFile}
COMMAND ${CMAKE_COMMAND} -E make_directory		COMMAND ${CMAKE_COMMAND} -E make_directory
${CMAKE_BINARY_DIR}/share/scan-build		${CMAKE_BINARY_DIR}/share/scan-build
Show All 19 Lines