This is an archive of the discontinued LLVM Phabricator instance.

Differential D120543

[NFC][AArch64][SME] Remove '#' prefix in PSEL test cases
ClosedPublic

Authored by HsiangKai on Feb 25 2022, 12:04 AM.

Details

Reviewers
c-rhodes
Commits
rG2cd675249d8d: [NFC][AArch64][SME] Remove '#' prefix in PSEL test cases
Summary

There is no need to prefix '#' for element index in PSEL.
This is a follow up of D111213.

Diff Detail

Unit TestsFailed

TimeTest
60,130 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
60,130 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,110 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c
60,040 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vlsegff.c
60,080 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c
View Full Test Results (10 Failed)

Event Timeline

HsiangKai created this revision.Feb 25 2022, 12:04 AM
Herald added a subscriber: kristof.beyls. · View Herald TranscriptFeb 25 2022, 12:04 AM
HsiangKai requested review of this revision.Feb 25 2022, 12:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2022, 12:04 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B151427: Diff 411335.Feb 25 2022, 12:46 AM
c-rhodes accepted this revision.Feb 25 2022, 12:58 AM

thanks for the patch!

This revision is now accepted and ready to land.Feb 25 2022, 12:58 AM
This revision was landed with ongoing or failed builds.Feb 25 2022, 1:24 AM
Closed by commit rG2cd675249d8d: [NFC][AArch64][SME] Remove '#' prefix in PSEL test cases (authored by HsiangKai). · Explain Why
This revision was automatically updated to reflect the committed changes.
HsiangKai added a commit: rG2cd675249d8d: [NFC][AArch64][SME] Remove '#' prefix in PSEL test cases.

Revision Contents

PathSize
llvm/
test/
MC/
AArch64/
SME/
16 lines

Diff 411335

llvm/test/MC/AArch64/SME/psel-diagnostics.s

Show All 19 Lines
psel p0, p0, p0.b[w16] psel p0, p0, p0.b[w16]
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: operand must be a register in range [w12, w15] // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: operand must be a register in range [w12, w15]
// CHECK-NEXT: psel p0, p0, p0.b[w16] // CHECK-NEXT: psel p0, p0, p0.b[w16]
// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
// --------------------------------------------------------------------------// // --------------------------------------------------------------------------//
// Invalid immediates // Invalid immediates
psel p0, p0, p0.b[w12, #16] psel p0, p0, p0.b[w12, 16]
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 15]. // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 15].
// CHECK-NEXT: psel p0, p0, p0.b[w12, #16] // CHECK-NEXT: psel p0, p0, p0.b[w12, 16]
// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
psel p0, p0, p0.h[w12, #8] psel p0, p0, p0.h[w12, 8]
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 7]. // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 7].
// CHECK-NEXT: psel p0, p0, p0.h[w12, #8] // CHECK-NEXT: psel p0, p0, p0.h[w12, 8]
// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
psel p0, p0, p0.s[w12, #4] psel p0, p0, p0.s[w12, 4]
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 3]. // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 3].
// CHECK-NEXT: psel p0, p0, p0.s[w12, #4] // CHECK-NEXT: psel p0, p0, p0.s[w12, 4]
// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
psel p0, p0, p0.d[w12, #2] psel p0, p0, p0.d[w12, 2]
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 1]. // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: immediate must be an integer in range [0, 1].
// CHECK-NEXT: psel p0, p0, p0.d[w12, #2] // CHECK-NEXT: psel p0, p0, p0.d[w12, 2]
// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: