This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][NFC] Remove redundant semi
ClosedPublic

Authored by HazardyKnusperkeks on Feb 22 2022, 2:30 PM.

Details

Summary

All "calls" have a semi, as they should, remove the one from the macro.

Diff Detail

Event Timeline

HazardyKnusperkeks requested review of this revision.Feb 22 2022, 2:30 PM
HazardyKnusperkeks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2022, 2:30 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan accepted this revision.Feb 22 2022, 4:24 PM
This revision is now accepted and ready to land.Feb 22 2022, 4:24 PM

I don't really understand this change. You say in the description that you remove the semicolon, but you actually add it.
Also, it's a common pattern not to add a semicolon and make all macro calls look like a normal statement (with a semi at the call place).
I'm not opposed but I don't see a reason for changing this.

owenpan requested changes to this revision.Feb 23 2022, 12:36 AM

Oops! For some reason, I thought the patch was removing the semi. See also D117301.

This revision now requires changes to proceed.Feb 23 2022, 12:36 AM

I don't really understand this change. You say in the description that you remove the semicolon, but you actually add it.
Also, it's a common pattern not to add a semicolon and make all macro calls look like a normal statement (with a semi at the call place).
I'm not opposed but I don't see a reason for changing this.

Just a messed up git diff command. I had some unstaged and uncommited changes in the same file. It's the other way around. I will update the diff.

owenpan accepted this revision.Feb 23 2022, 12:26 PM
This revision is now accepted and ready to land.Feb 23 2022, 12:26 PM
curdeius accepted this revision.Feb 23 2022, 1:00 PM
This revision was landed with ongoing or failed builds.Feb 26 2022, 12:23 PM
This revision was automatically updated to reflect the committed changes.