All "calls" have a semi, as they should, remove the one from the macro.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I don't really understand this change. You say in the description that you remove the semicolon, but you actually add it.
Also, it's a common pattern not to add a semicolon and make all macro calls look like a normal statement (with a semi at the call place).
I'm not opposed but I don't see a reason for changing this.
Comment Actions
Just a messed up git diff command. I had some unstaged and uncommited changes in the same file. It's the other way around. I will update the diff.