This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix the get/put long_double_ru_RU tests on Apple platforms
ClosedPublic

Authored by mstorsjo on Feb 22 2022, 4:02 AM.

Details

Summary

This fixes issue #45084 (https://llvm.org/PR45739).

Remove unnecessary trailing spaces after the "RUB" international
currency symbol (and after the plain number in some parts of the
put_long_double test).

The previously commented out code never seemed to be passing in any
current configuration; the whole tests were XFAILed on all other
platforms than Apple platforms, and on Apple platforms, some parts
of the tests (where the trailing space made a difference) were
ifdeffed out.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Feb 22 2022, 4:02 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2022, 4:02 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Feb 23 2022, 9:40 AM

Thanks for the fix. Based on the fact the CI is still happy LGTM.

Quuxplusone accepted this revision.Feb 23 2022, 2:37 PM

Yeesh, yeah, LGTM. I'd characterize this PR as follows, and feel free to take any of this wording into your commit message:

Both of these test files are XFAIL: netbsd || linux || LIBCXX-WINDOWS-FIXME, and then have some of their test cases commented out when __APPLE__. This PR comments-in those test cases and adjusts them all to work on Apple, while leaving the test XFAILed on NetBSD, Linux, and Windows.

This revision is now accepted and ready to land.Feb 23 2022, 2:37 PM

Thanks a lot for fixing this :)

Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2022, 12:34 PM