This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] replace C++ function type defintion in the C API's Interfaces.h
ClosedPublic

Authored by fuzzypixelz on Feb 21 2022, 5:36 AM.

Details

Summary

Clearly this something of a typo, and it obviously doesn't even compile.

Diff Detail

Event Timeline

fuzzypixelz created this revision.Feb 21 2022, 5:36 AM
fuzzypixelz requested review of this revision.Feb 21 2022, 5:36 AM

Apparently, it's a result of running clang-tidy in https://reviews.llvm.org/rG2071e7204dda669013113f5b78257dea81ec57af.
I'm not sure if this is a clang-tidy configuration problem or simply an error on behalf of the submitter.

ftynse accepted this revision.Feb 21 2022, 5:41 AM
ftynse added a subscriber: ftynse.

Obviously it does compile if you use a C++ compiler :)

This revision is now accepted and ready to land.Feb 21 2022, 5:41 AM

We should ping Mehdi on that one, perhaps this dir needs to be excluded in the automatic tool he has planned.