This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse][pytaco] test with 3-dim tensor and scalar
ClosedPublic

Authored by aartbik on Feb 18 2022, 1:45 PM.

Diff Detail

Event Timeline

aartbik created this revision.Feb 18 2022, 1:45 PM
aartbik requested review of this revision.Feb 18 2022, 1:45 PM
aartbik updated this revision to Diff 410021.Feb 18 2022, 2:08 PM

comment typo

aartbik added inline comments.Feb 18 2022, 2:13 PM
mlir/test/Integration/Dialect/SparseTensor/taco/test_Tensor.py
20

note that this needs to assert (as long as we do not support the compression in our PyTACO MLIR conversion methods)

28

syntax for scalar access should work

bixia accepted this revision.Feb 18 2022, 2:14 PM
bixia added inline comments.
mlir/test/Integration/Dialect/SparseTensor/taco/test_Tensor.py
5

this import is not used?

This revision is now accepted and ready to land.Feb 18 2022, 2:14 PM
aartbik updated this revision to Diff 410025.Feb 18 2022, 2:14 PM

switch back to all-compressed for the time being....

aartbik marked an inline comment as done.Feb 18 2022, 2:15 PM
aartbik added inline comments.
mlir/test/Integration/Dialect/SparseTensor/taco/test_Tensor.py
5

L43?

This revision was automatically updated to reflect the committed changes.
aartbik marked an inline comment as done.