This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN] Add test for optnone function.
ClosedPublic

Authored by fmayer on Feb 17 2022, 4:52 PM.

Diff Detail

Event Timeline

fmayer requested review of this revision.Feb 17 2022, 4:52 PM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2022, 4:52 PM
eugenis added inline comments.Feb 23 2022, 1:19 PM
llvm/test/Instrumentation/HWAddressSanitizer/use-after-scope.ll
115

Should this say [[TMP11]]? It is otherwise unused.

Overall I feel this test is too detailed and potentially brittle. If you want to check that tagging/untagging happens within lifetime bounds, that can be done with just a few lines.

Also, I could be misreading, but does this show __hwasan_tag_memory after lifetime.end?

fmayer added inline comments.Feb 23 2022, 2:00 PM
llvm/test/Instrumentation/HWAddressSanitizer/use-after-scope.ll
115

This is copy-pasted from the test just above, just with added _optnull.

fmayer added inline comments.Mar 1 2022, 10:46 AM
llvm/test/Instrumentation/HWAddressSanitizer/use-after-scope.ll
115

Rebased this to a CL that fixes this problem. PTAL.

eugenis accepted this revision.Mar 1 2022, 11:19 AM

LGTM

This revision is now accepted and ready to land.Mar 1 2022, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2022, 12:31 PM
This revision was landed with ongoing or failed builds.Mar 1 2022, 2:49 PM
This revision was automatically updated to reflect the committed changes.