This is an archive of the discontinued LLVM Phabricator instance.

Differential D120030

Remove duplicated code for printing the `uwtable` attribute (NFC)
ClosedPublic

Authored by chill on Feb 17 2022, 2:44 AM.

Details

Reviewers
chill
Commits
rG030503e17cae: Remove duplicated code for printing the `uwtable` attribute (NFC)
Summary

Committed as obvious.

Diff Detail

Event Timeline

chill created this revision.Feb 17 2022, 2:44 AM
Herald added subscribers: dexonsmith, jdoerfert, hiraditya. · View Herald TranscriptFeb 17 2022, 2:44 AM
chill requested review of this revision.Feb 17 2022, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2022, 2:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
chill accepted this revision.Feb 17 2022, 2:45 AM
This revision is now accepted and ready to land.Feb 17 2022, 2:45 AM
chill mentioned this in D114543: Extend the `uwtable` attribute with unwind table kind.Feb 17 2022, 2:45 AM
Harbormaster completed remote builds in B150179: Diff 409561.Feb 17 2022, 3:14 AM
This revision was landed with ongoing or failed builds.Feb 17 2022, 4:25 AM
Closed by commit rG030503e17cae: Remove duplicated code for printing the `uwtable` attribute (NFC) (authored by chill). · Explain Why
This revision was automatically updated to reflect the committed changes.
chill added a commit: rG030503e17cae: Remove duplicated code for printing the `uwtable` attribute (NFC).

Revision Contents

PathSize
llvm/
lib/
IR/
8 lines

Diff 409587

llvm/lib/IR/Attributes.cpp

Show First 20 Lines • Show All 440 Lines • ▼ Show 20 Lines if (hasAttribute(Attribute::UWTable)) {
UWTableKind Kind = getUWTableKind(); UWTableKind Kind = getUWTableKind();
if (Kind != UWTableKind::None) { if (Kind != UWTableKind::None) {
return Kind == UWTableKind::Default return Kind == UWTableKind::Default
? "uwtable" ? "uwtable"
: ("uwtable(" + : ("uwtable(" +
Twine(Kind == UWTableKind::Sync ? "sync" : "async") + ")") Twine(Kind == UWTableKind::Sync ? "sync" : "async") + ")")
.str(); .str();
} }
if (Kind != UWTableKind::None) {
if (Kind == UWTableKind::Default)
return "uwtable";
return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") +
")")
.str();
}
} }
// Convert target-dependent attributes to strings of the form: // Convert target-dependent attributes to strings of the form:
// //
// "kind" // "kind"
// "kind" = "value" // "kind" = "value"
// //
if (isStringAttribute()) { if (isStringAttribute()) {
▲ Show 20 Lines • Show All 1,564 Lines • Show Last 20 Lines