This is an archive of the discontinued LLVM Phabricator instance.

[libc++] LWG2148, LWG2543: Enable std::hash<Enum> in C++03 and C++11
ClosedPublic

Authored by Quuxplusone on Feb 15 2022, 1:57 PM.

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.Feb 15 2022, 1:57 PM
Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptFeb 15 2022, 1:57 PM
Quuxplusone edited the summary of this revision. (Show Details)

On second thought, don't git rm enum.compile.fail.cpp — it's the only test coverage we get for the "non-enabled" case in C++03 mode, because non_enum.pass.cpp isn't C++03-friendly.

ldionne accepted this revision.Feb 16 2022, 6:25 AM
ldionne added inline comments.
libcxx/test/std/utilities/function.objects/unord.hash/enum.pass.cpp
16

Can we remove this "not very portable" comment?

This revision is now accepted and ready to land.Feb 16 2022, 6:25 AM
libcxx/include/__functional/hash.h