This is an archive of the discontinued LLVM Phabricator instance.

Differential D119882

[buildbot] Enable CCACHE for all stages of ThinLTO WPD worker
ClosedPublic

Authored by tejohnson on Feb 15 2022, 12:14 PM.

Details

Reviewers
gkistanova
mtrofin
Commits
rZORG3149a081f81c: [buildbot] Enable CCACHE for all stages of ThinLTO WPD worker
Summary

Previously CCACHE was only enabled for the last of 4 build stages.
Enable for all stages to speed up bot.

Diff Detail

Event Timeline

tejohnson created this revision.Feb 15 2022, 12:14 PM
Herald added a subscriber: inglorion. · View Herald TranscriptFeb 15 2022, 12:14 PM
tejohnson requested review of this revision.Feb 15 2022, 12:14 PM
Harbormaster completed remote builds in B149792: Diff 409002.Feb 15 2022, 12:14 PM
mtrofin accepted this revision.Feb 15 2022, 12:16 PM
mtrofin added inline comments.
buildbot/osuosl/master/config/builders.py
1305

I assume lto gets extra_configure_args + extra_configure_args_lto_stage

This revision is now accepted and ready to land.Feb 15 2022, 12:16 PM
tejohnson added inline comments.Feb 15 2022, 12:19 PM
buildbot/osuosl/master/config/builders.py
1305

Correct: https://github.com/llvm/llvm-zorg/blob/e2862623d5a4517860bb38fcc79759a497dce47f/zorg/buildbot/builders/ClangLTOBuilder.py#L341

gkistanova accepted this revision.Feb 15 2022, 12:57 PM

Thanks, Teresa!
LGTM

Closed by commit rZORG3149a081f81c: [buildbot] Enable CCACHE for all stages of ThinLTO WPD worker (authored by tejohnson). · Explain WhyFeb 15 2022, 1:10 PM
This revision was automatically updated to reflect the committed changes.
tejohnson added a commit: rZORG3149a081f81c: [buildbot] Enable CCACHE for all stages of ThinLTO WPD worker.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
4 lines

Diff 409031

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 1,293 Lines • ▼ Show 20 Lines# LTO and ThinLTO builders.
{'name' : "clang-with-thin-lto-wpd-ubuntu", {'name' : "clang-with-thin-lto-wpd-ubuntu",
'tags' : ["clang","lld","LTO"], 'tags' : ["clang","lld","LTO"],
'workernames' : ["thinlto-x86-64-bot1", "thinlto-x86-64-bot2"], 'workernames' : ["thinlto-x86-64-bot1", "thinlto-x86-64-bot2"],
'builddir': "clang-with-thin-lto-wpd-ubuntu", 'builddir': "clang-with-thin-lto-wpd-ubuntu",
'factory' : ClangLTOBuilder.getClangWithLTOBuildFactory( 'factory' : ClangLTOBuilder.getClangWithLTOBuildFactory(
jobs=72, jobs=72,
lto='thin', lto='thin',
extra_configure_args_lto_stage=[ extra_configure_args=[
'-DLLVM_CCACHE_BUILD=ON', '-DLLVM_CCACHE_BUILD=ON',
],
extra_configure_args_lto_stage=[
mtrofinUnsubmitted
Done
ReplyInline Actions

I assume lto gets extra_configure_args + extra_configure_args_lto_stage

mtrofin: I assume lto gets `extra_configure_args + extra_configure_args_lto_stage`
tejohnsonAuthorUnsubmitted
Done
ReplyInline Actions

Correct: https://github.com/llvm/llvm-zorg/blob/e2862623d5a4517860bb38fcc79759a497dce47f/zorg/buildbot/builders/ClangLTOBuilder.py#L341

tejohnson: Correct: https://github.com/llvm/llvm-zorg/blob/e2862623d5a4517860bb38fcc79759a497dce47f/zorg/b…
'-DCMAKE_CXX_FLAGS=-O3 -Xclang -fwhole-program-vtables -fno-split-lto-unit', '-DCMAKE_CXX_FLAGS=-O3 -Xclang -fwhole-program-vtables -fno-split-lto-unit',
'-DCMAKE_C_FLAGS=-O3 -Xclang -fwhole-program-vtables -fno-split-lto-unit', '-DCMAKE_C_FLAGS=-O3 -Xclang -fwhole-program-vtables -fno-split-lto-unit',
'-DCMAKE_EXE_LINKER_FLAGS=-Wl,--lto-whole-program-visibility -fuse-ld=lld'])}, '-DCMAKE_EXE_LINKER_FLAGS=-Wl,--lto-whole-program-visibility -fuse-ld=lld'])},
{'name' : "clang-with-lto-ubuntu", {'name' : "clang-with-lto-ubuntu",
'tags' : ["clang","lld","LTO"], 'tags' : ["clang","lld","LTO"],
'workernames' : ["as-worker-91"], 'workernames' : ["as-worker-91"],
'builddir': "clang-with-lto-ubuntu", 'builddir': "clang-with-lto-ubuntu",
▲ Show 20 Lines • Show All 979 Lines • Show Last 20 Lines