This is an archive of the discontinued LLVM Phabricator instance.

Differential D119869

[AMDGPU] Do not define GET_INSTRINFO_SCHED_ENUM
ClosedPublic

Authored by rampitec on Feb 15 2022, 11:21 AM.

Details

Reviewers
kzhuravl
Commits
rG29a0e0a9e54f: [AMDGPU] Do not define GET_INSTRINFO_SCHED_ENUM
Summary

Autogenerated names are too long and break compilation on Windows,
while we do not need this enum at all.

Diff Detail

Event Timeline

rampitec created this revision.Feb 15 2022, 11:21 AM
Herald added subscribers: foad, kerbowa, hiraditya and 6 others. · View Herald TranscriptFeb 15 2022, 11:21 AM
rampitec requested review of this revision.Feb 15 2022, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2022, 11:21 AM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B149768: Diff 408973.Feb 15 2022, 12:45 PM
kzhuravl accepted this revision.Feb 15 2022, 12:50 PM

lgtm, thanks

This revision is now accepted and ready to land.Feb 15 2022, 12:50 PM
This revision was landed with ongoing or failed builds.Feb 15 2022, 1:02 PM
Closed by commit rG29a0e0a9e54f: [AMDGPU] Do not define GET_INSTRINFO_SCHED_ENUM (authored by rampitec). · Explain Why
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG29a0e0a9e54f: [AMDGPU] Do not define GET_INSTRINFO_SCHED_ENUM.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
MCTargetDesc/
1 line

Diff 409027

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.h

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 LinescreateAMDGPUELFObjectWriter(bool Is64Bit, uint8_t OSABI,
bool HasRelocationAddend, uint8_t ABIVersion); bool HasRelocationAddend, uint8_t ABIVersion);
} // End llvm namespace } // End llvm namespace
#define GET_REGINFO_ENUM #define GET_REGINFO_ENUM
#include "AMDGPUGenRegisterInfo.inc" #include "AMDGPUGenRegisterInfo.inc"
#define GET_INSTRINFO_ENUM #define GET_INSTRINFO_ENUM
#define GET_INSTRINFO_OPERAND_ENUM #define GET_INSTRINFO_OPERAND_ENUM
#define GET_INSTRINFO_SCHED_ENUM
#include "AMDGPUGenInstrInfo.inc" #include "AMDGPUGenInstrInfo.inc"
#define GET_SUBTARGETINFO_ENUM #define GET_SUBTARGETINFO_ENUM
#include "AMDGPUGenSubtargetInfo.inc" #include "AMDGPUGenSubtargetInfo.inc"
#endif #endif