This is an archive of the discontinued LLVM Phabricator instance.

Differential D119800

[WebAssembly] Add TLS FileCheck lines to Wasm SjLj test
ClosedPublic

Authored by aheejin on Feb 14 2022, 6:08 PM.

Details

Reviewers
sbc100
Commits
rGb8438a697573: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test

Diff Detail

Event Timeline

aheejin created this revision.Feb 14 2022, 6:08 PM
Herald added subscribers: wingo, ecnelises, sunfish and 2 others. · View Herald TranscriptFeb 14 2022, 6:08 PM
aheejin requested review of this revision.Feb 14 2022, 6:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 6:08 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aheejin retitled this revision from [WebAssembly] Add TLS FileCheck lines to Wasm SjLj to [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test.Feb 14 2022, 6:08 PM
aheejin added inline comments.
llvm/test/CodeGen/WebAssembly/lower-wasm-sjlj.ll
20

In TLS mode, this line contains #0, which makes coming up with a CHECK line that works for both TLS and non-TLS annoying, and I don't think this line worth making two separate TLS and NO-TLS check lines, so I'm cutting this off.

Harbormaster completed remote builds in B149566: Diff 408679.Feb 14 2022, 6:57 PM
sbc100 accepted this revision.Feb 15 2022, 8:32 AM
This revision is now accepted and ready to land.Feb 15 2022, 8:32 AM
This revision was landed with ongoing or failed builds.Feb 15 2022, 3:52 PM
Closed by commit rGb8438a697573: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test (authored by aheejin). · Explain Why
This revision was automatically updated to reflect the committed changes.
aheejin added a commit: rGb8438a697573: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test.
aheejin mentioned this in D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.Feb 16 2022, 11:42 PM

Revision Contents

PathSize
llvm/
test/
CodeGen/
WebAssembly/
4 lines
12 lines

Diff 409082

llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll

; RUN: opt < %s -wasm-lower-em-ehsjlj -enable-emscripten-sjlj -S | FileCheck %s --check-prefixes=CHECK,NO-TLS -DPTR=i32 ; RUN: opt < %s -wasm-lower-em-ehsjlj -enable-emscripten-sjlj -S | FileCheck %s --check-prefixes=CHECK,NO-TLS -DPTR=i32
; RUN: opt < %s -wasm-lower-em-ehsjlj -enable-emscripten-sjlj -S --mattr=+atomics,+bulk-memory | FileCheck %s --check-prefixes=CHECK,TLS -DPTR=i32 ; RUN: opt < %s -wasm-lower-em-ehsjlj -enable-emscripten-sjlj -S --mattr=+atomics,+bulk-memory | FileCheck %s --check-prefixes=CHECK,TLS -DPTR=i32
; RUN: opt < %s -wasm-lower-em-ehsjlj -enable-emscripten-sjlj --mtriple=wasm64-unknown-unknown -data-layout="e-m:e-p:64:64-i64:64-n32:64-S128" -S | FileCheck %s --check-prefixes=CHECK -DPTR=i64 ; RUN: opt < %s -wasm-lower-em-ehsjlj -enable-emscripten-sjlj --mtriple=wasm64-unknown-unknown -data-layout="e-m:e-p:64:64-i64:64-n32:64-S128" -S | FileCheck %s --check-prefixes=CHECK -DPTR=i64
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown" target triple = "wasm32-unknown-unknown"
%struct.__jmp_buf_tag = type { [6 x i32], i32, [32 x i32] } %struct.__jmp_buf_tag = type { [6 x i32], i32, [32 x i32] }
@global_var = global i32 0, align 4 @global_var = global i32 0, align 4
; NO-TLS-DAG: __THREW__ = external global [[PTR]] ; NO-TLS-DAG: __THREW__ = external global [[PTR]]
; NO-TLS-DAG: __threwValue = external global [[PTR]] ; NO-TLS-DAG: __threwValue = external global [[PTR]]
; TLS-DAG: __THREW__ = external thread_local global i32 ; TLS-DAG: __THREW__ = external thread_local global [[PTR]]
; TLS-DAG: __threwValue = external thread_local global i32 ; TLS-DAG: __threwValue = external thread_local global [[PTR]]
@global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* @longjmp, align 4 @global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* @longjmp, align 4
; CHECK-DAG: @global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* bitcast (void ([[PTR]], i32)* @emscripten_longjmp to void (%struct.__jmp_buf_tag*, i32)*) ; CHECK-DAG: @global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* bitcast (void ([[PTR]], i32)* @emscripten_longjmp to void (%struct.__jmp_buf_tag*, i32)*)
; Test a simple setjmp - longjmp sequence ; Test a simple setjmp - longjmp sequence
define void @setjmp_longjmp() { define void @setjmp_longjmp() {
; CHECK-LABEL: @setjmp_longjmp ; CHECK-LABEL: @setjmp_longjmp
entry: entry:
%buf = alloca [1 x %struct.__jmp_buf_tag], align 16 %buf = alloca [1 x %struct.__jmp_buf_tag], align 16
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines

llvm/test/CodeGen/WebAssembly/lower-wasm-sjlj.ll

; RUN: opt < %s -wasm-lower-em-ehsjlj -wasm-enable-sjlj -S | FileCheck %s -DPTR=i32 ; RUN: opt < %s -wasm-lower-em-ehsjlj -wasm-enable-sjlj -S | FileCheck %s --check-prefixes=CHECK,NO-TLS -DPTR=i32
; RUN: opt < %s -wasm-lower-em-ehsjlj -wasm-enable-sjlj --mtriple=wasm64-unknown-unknown -data-layout="e-m:e-p:64:64-i64:64-n32:64-S128" -S | FileCheck %s -DPTR=i64 ; RUN: opt < %s -wasm-lower-em-ehsjlj -wasm-enable-sjlj -S --mattr=+atomics,+bulk-memory | FileCheck %s --check-prefixes=CHECK,TLS -DPTR=i32
; RUN: opt < %s -wasm-lower-em-ehsjlj -wasm-enable-sjlj --mtriple=wasm64-unknown-unknown -data-layout="e-m:e-p:64:64-i64:64-n32:64-S128" -S | FileCheck %s --check-prefixes CHECK -DPTR=i64
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown" target triple = "wasm32-unknown-unknown"
%struct.__jmp_buf_tag = type { [6 x i32], i32, [32 x i32] } %struct.__jmp_buf_tag = type { [6 x i32], i32, [32 x i32] }
; NO-TLS-DAG: __THREW__ = external global [[PTR]]
; NO-TLS-DAG: __threwValue = external global [[PTR]]
; TLS-DAG: __THREW__ = external thread_local global [[PTR]]
; TLS-DAG: __threwValue = external thread_local global [[PTR]]
@global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* @longjmp, align 4 @global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* @longjmp, align 4
; CHECK-DAG: @global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* bitcast (void (i8*, i32)* @__wasm_longjmp to void (%struct.__jmp_buf_tag*, i32)*) ; CHECK-DAG: @global_longjmp_ptr = global void (%struct.__jmp_buf_tag*, i32)* bitcast (void (i8*, i32)* @__wasm_longjmp to void (%struct.__jmp_buf_tag*, i32)*)
; Test a simple setjmp - longjmp sequence ; Test a simple setjmp - longjmp sequence
define void @setjmp_longjmp() { define void @setjmp_longjmp() {
; CHECK-LABEL: @setjmp_longjmp() personality {{.*}} @__gxx_wasm_personality_v0 ; CHECK-LABEL: @setjmp_longjmp()
aheejinAuthorUnsubmitted
Done
ReplyInline Actions

In TLS mode, this line contains #0, which makes coming up with a CHECK line that works for both TLS and non-TLS annoying, and I don't think this line worth making two separate TLS and NO-TLS check lines, so I'm cutting this off.

aheejin: In TLS mode, this line contains `#0`, which makes coming up with a `CHECK` line that works for…
entry: entry:
%buf = alloca [1 x %struct.__jmp_buf_tag], align 16 %buf = alloca [1 x %struct.__jmp_buf_tag], align 16
%arraydecay = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %buf, i32 0, i32 0 %arraydecay = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %buf, i32 0, i32 0
%call = call i32 @setjmp(%struct.__jmp_buf_tag* %arraydecay) #0 %call = call i32 @setjmp(%struct.__jmp_buf_tag* %arraydecay) #0
%arraydecay1 = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %buf, i32 0, i32 0 %arraydecay1 = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %buf, i32 0, i32 0
call void @longjmp(%struct.__jmp_buf_tag* %arraydecay1, i32 1) #1 call void @longjmp(%struct.__jmp_buf_tag* %arraydecay1, i32 1) #1
unreachable unreachable
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines