This is an archive of the discontinued LLVM Phabricator instance.

[libc++][AIX] Remove "pragma priority" from locale.cpp
ClosedPublic

Authored by xingxue on Feb 14 2022, 12:30 PM.

Details

Summary

The pragma priority guarded for AIX in locale.cpp is no longer useful and is ignored by the current AIX build compilers. This patch removes it from the source.

Diff Detail

Event Timeline

xingxue requested review of this revision.Feb 14 2022, 12:30 PM
xingxue created this revision.
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 14 2022, 12:30 PM
libcxx/src/locale.cpp
131

The pragma priority guarded for AIX in locale.cpp is no longer useful and is ignored by the current AIX build compilers. This patch removes it from the source.

@xingxue, this is no longer useful because you observed that compiling the file results in no functions being generated to perform non-local initialization?

xingxue added inline comments.Feb 14 2022, 1:28 PM
libcxx/src/locale.cpp
131

Right, there are no static constructor functions (__sinit*()) in the resulting locale.cpp.o file.

LGTM

@ldionne, can you approve? The change only affects AIX.

ldionne accepted this revision.Feb 14 2022, 3:18 PM

Thanks for cleaning up.

This revision is now accepted and ready to land.Feb 14 2022, 3:18 PM
This revision was automatically updated to reflect the committed changes.