This change will make it possible to track exported symbols in more
configurations, notably the Apple system one, where we disable incomplete
features and the debug mode. Also, as a fly-by fix, shorten the name for
whether new is in libc++ or not.
Details
- Reviewers
Mordante ldionne - Group Reviewers
Restricted Project - Commits
- rG0e628a783b93: [libc++] Take more knobs into account when generating ABI lists
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I assume you'll add more abilist when the CI produces them?
I wonder whether we should use noincomplete or move them to the experimental library as you suggested earlier. I posted this question in Discord.
I think the only ABI list missing is the one for arm64 apple-system. All the other CI configurations I added check-abi-list to are reusing existing ABI list files.
I wonder whether we should use noincomplete or move them to the experimental library as you suggested earlier. I posted this question in Discord.
Replied on Discord, but TLDR is that I think we should handle that separately and avoid blocking this PR on it. Basically, what we want to do is merge the notion of incomplete features and experimental features, but that's a larger thing on its own and it should be coupled to compiler support for something like -fexperimental.
Don't run ABI list for sanitizers since the ABI is different in subtle ways (e.g. size of objects).
Add ABI list for arm64 apple-system configuration.
The only failing job is generic-cxx20 on macOS x86_64. I'll re-run that locally on top of latest main to save CI resources, and I'll ship this if that passes. Thanks for taking a look!