AMDGPU: Set MCAsmInfo::PointerSize

[arsenm]

Summary

The test should need an update / serve as the test forD11969

[rampitec]

LGTM.

[• tstellarAMD]

test/CodeGen/AMDGPU/basic-debug-info.ll

35

Do we need this clang version in the test? Can any of this other metadata be safely dropped?

[arsenm]

Remove extra metadata

[• tstellarAMD]

Do we still need this patch?

[arsenm]

In D11972#299510, @tstellarAMD wrote:

Do we still need this patch?

I think so

test/CodeGen/AMDGPU/basic-debug-info.ll

35

The clang version should be droppable. Most of it probably can be, I'm not exactly sure what the minimum required is

[arsenm]

It seems the .debug_info section isn't emitted anymore. Is that intentional?

[kzhuravl]

In D11972#664174, @arsenm wrote:

It seems the .debug_info section isn't emitted anymore. Is that intentional?

.debug_info section is not emitted because you have emissionKind: 0. Change it to emissionKind: FullDebug to get debug info emitted.

test/CodeGen/AMDGPU/basic-debug-info.ll

9

• add !dbg !4 before {

19

• emissionKind: 0 -> emissionKind: FullDebug
• remove subprograms: !3

23

• missing distinct before DISubprogram
• function: void ()* @basic_debug_info -> unit: !0

[arsenm]

r294031

test/CodeGen/AMDGPU/basic-debug-info.ll

19

This was the real problem. The other problems I managed to fix or otherwise it fails to parse

lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp

 //===-- MCTargetDesc/AMDGPUMCAsmInfo.cpp - Assembly Info ------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 /// \file
 //===----------------------------------------------------------------------===//
 
 #include "AMDGPUMCAsmInfo.h"
+#include "llvm/ADT/Triple.h"
 
 using namespace llvm;
+
 AMDGPUMCAsmInfo::AMDGPUMCAsmInfo(const Triple &TT) : MCAsmInfoELF() {
+  PointerSize = (TT.getArch() == Triple::amdgcn) ? 8 : 4;
   HasSingleParameterDotFile = false;
   //===------------------------------------------------------------------===//
   MaxInstLength = 16;
   SeparatorString = "\n";
   CommentString = ";";
   PrivateLabelPrefix = "";
   InlineAsmStart = ";#ASMSTART";
   InlineAsmEnd = ";#ASMEND";

test/CodeGen/AMDGPU/basic-debug-info.ll

+; RUN: llc -march=amdgcn -mtriple=amdgcn-unknown-amdhsa < %s | FileCheck %s
+
+; FIXME: Should be .byte 8 for pointer size
+
+; CHECK-LABEL: {{^}}basic_debug_info:
+; CHECK: .section .debug_info
+; CHECK: .byte  4                               ; Address Size (in bytes)
+define void @basic_debug_info() #0 {
+entry:
+  ret void, !dbg !16
+}
+
+attributes #0 = { nounwind "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
+
+!llvm.dbg.cu = !{!0}
+!opencl.kernels = !{!7}
+!llvm.module.flags = !{!13, !14}
+!llvm.ident = !{!15}
+
+!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.8.0 (trunk 244715) (llvm/trunk 244718)", isOptimized: false, runtimeVersion: 0, emissionKind: 1, enums: !2, subprograms: !3)
+!1 = !DIFile(filename: "/tmp/basic-debug-info.cl", directory: "/Users/matt/src/llvm/build_debug")
+!2 = !{}
+!3 = !{!4}
+!4 = !DISubprogram(name: "basic_debug_info", scope: !1, file: !1, line: 1, type: !5, isLocal: false, isDefinition: true, scopeLine: 2, isOptimized: false, function: void ()* @basic_debug_info, variables: !2)
+!5 = !DISubroutineType(types: !6)
+!6 = !{null}
+!7 = !{void ()* @basic_debug_info, !8, !9, !10, !11, !12}
+!8 = !{!"kernel_arg_addr_space"}
+!9 = !{!"kernel_arg_access_qual"}
+!10 = !{!"kernel_arg_type"}
+!11 = !{!"kernel_arg_base_type"}
+!12 = !{!"kernel_arg_type_qual"}
+!13 = !{i32 2, !"Dwarf Version", i32 4}
+!14 = !{i32 2, !"Debug Info Version", i32 3}
+!15 = !{!"clang version 3.8.0 (trunk 244715) (llvm/trunk 244718)"}
+!16 = !DILocation(line: 4, column: 1, scope: !4)