This is an archive of the discontinued LLVM Phabricator instance.

fix a typo
ClosedPublic

Authored by fsb4000 on Feb 14 2022, 1:17 AM.

Diff Detail

Event Timeline

fsb4000 requested review of this revision.Feb 14 2022, 1:17 AM
fsb4000 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 1:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo accepted this revision.Feb 14 2022, 1:36 AM
mstorsjo added a subscriber: mstorsjo.

LGTM (but a libc++ approver will need to approve too).

For pushing your commit, can you provide your preferred git author line, i.e. Real Name <email@address>?

For pushing your commit, can you provide your preferred git author line, i.e. Real Name <email@address>?

As a comment here or do I need to set it somewhere in the account settings (https://reviews.llvm.org/settings/user/fsb4000/ or others)?

Igor Zhukov <fsb4000@yandex.ru>

Игорь Жуков - same name but in Russian.

For pushing your commit, can you provide your preferred git author line, i.e. Real Name <email@address>?

As a comment here or do I need to set it somewhere in the account settings (https://reviews.llvm.org/settings/user/fsb4000/ or others)?

Igor Zhukov <fsb4000@yandex.ru>

Игорь Жуков - same name but in Russian.

Thanks! A comment here is fine. While you might have this set up in Phabricator properly already, it's unfortunately not always trivially available for others to pick up when applying your patch.

philnik accepted this revision as: philnik.Feb 14 2022, 3:41 AM
Quuxplusone accepted this revision.Feb 14 2022, 7:58 AM
This revision is now accepted and ready to land.Feb 14 2022, 7:58 AM
This revision was automatically updated to reflect the committed changes.

Landed — thanks!