Details
- Reviewers
ldionne • Quuxplusone var-const Mordante - Group Reviewers
Restricted Project - Commits
- rGac428df47ada: [libc++] Replace _VSTD with std in __ranges/
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Assuming this is a completely mechanical sed -i -e s/_VSTD::/std::/g ../libcxx/include/__ranges/*.h, and assuming that you'll actually redo the sed immediately before pushing it (to avoid any merge/rebase conflicts), this seems technically fine to me.
My impression is that we absolutely don't want to do this kind of replacement on e.g. __algorithm/, __memory/, etc, because that would annoy downstream vendors; but perhaps __ranges/ is so new that it's a special case? Therefore I defer to @ldionne on this more-political-than-technical question.
LGTM from my side especially since there were no objections on Discord for the change to ranges.
However since I've no patches for ranges that can be conflicting I leave approval to those who work actively in the ranges code.
LGTM, but please make sure you re-run the sed before committing, in case there were race conditions.
Also, I looked at the patch and that seems to be the case, but I am assuming that this is purely a change from _VSTD:: to std:: (and so technically we could make this patch a no-op by reverting to _VSTD::). If that's not the case, please call it out.