This is an archive of the discontinued LLVM Phabricator instance.

Differential D119491

[libc++] Remove unused include from ranges_swap_ranges.h
ClosedPublic

Authored by jloser on Feb 10 2022, 3:15 PM.

Details

Reviewers
ldionne
• Quuxplusone
var-const
philnik
Group Reviewers
Restricted Project
Commits
rG36fba521d987: [libc++] Remove unused include from ranges_swap_ranges.h
Summary

ranges_swap_ranges.h includes <type_traits> but does not seem to require
anything from it. Remove the include.

Diff Detail

Event Timeline

jloser requested review of this revision.Feb 10 2022, 3:15 PM
jloser created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 3:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision as: philnik.Feb 10 2022, 3:19 PM

I haven't seen any use, so if CI is OK with it it LGTM.

libcxx/include/__algorithm/ranges_swap_ranges.h
46

You can replace _VSTD with std if you want to in this patch.

• Quuxplusone accepted this revision.Feb 10 2022, 3:27 PM

LGTM if it looks good to CI. :)

This revision is now accepted and ready to land.Feb 10 2022, 3:27 PM
jloser added inline comments.Feb 10 2022, 3:28 PM
libcxx/include/__algorithm/ranges_swap_ranges.h
46

Nah, I think that we should s/_VSTD/std in all of ranges in one patch if we're going to do that.

philnik added inline comments.Feb 10 2022, 3:30 PM
libcxx/include/__algorithm/ranges_swap_ranges.h
46

Right, I wanted to make a PR for that 😄 . Thanks for reminding me.

Harbormaster completed remote builds in B148856: Diff 407696.Feb 10 2022, 11:30 PM
ldionne accepted this revision.Feb 11 2022, 8:32 AM
This revision was landed with ongoing or failed builds.Feb 11 2022, 9:29 AM
Closed by commit rG36fba521d987: [libc++] Remove unused include from ranges_swap_ranges.h (authored by • joe_loser). · Explain Why
This revision was automatically updated to reflect the committed changes.
• joe_loser added a commit: rG36fba521d987: [libc++] Remove unused include from ranges_swap_ranges.h.

Revision Contents

PathSize
libcxx/
include/
__algorithm/
1 line

Diff 407915

libcxx/include/__algorithm/ranges_swap_ranges.h

Show All 11 Lines
#include <__algorithm/in_in_result.h> #include <__algorithm/in_in_result.h>
#include <__config> #include <__config>
#include <__iterator/concepts.h> #include <__iterator/concepts.h>
#include <__iterator/iter_swap.h> #include <__iterator/iter_swap.h>
#include <__ranges/access.h> #include <__ranges/access.h>
#include <__ranges/concepts.h> #include <__ranges/concepts.h>
#include <__ranges/dangling.h> #include <__ranges/dangling.h>
#include <__utility/move.h> #include <__utility/move.h>
#include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#ifndef _LIBCPP_HAS_NO_CONCEPTS #ifndef _LIBCPP_HAS_NO_CONCEPTS
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
Show All 10 Lines template <input_iterator _I1, sentinel_for<_I1> _S1,
requires indirectly_swappable<_I1, _I2> requires indirectly_swappable<_I1, _I2>
_LIBCPP_HIDE_FROM_ABI constexpr swap_ranges_result<_I1, _I2> _LIBCPP_HIDE_FROM_ABI constexpr swap_ranges_result<_I1, _I2>
operator()(_I1 __first1, _S1 __last1, _I2 __first2, _S2 __last2) const { operator()(_I1 __first1, _S1 __last1, _I2 __first2, _S2 __last2) const {
while (__first1 != __last1 && __first2 != __last2) { while (__first1 != __last1 && __first2 != __last2) {
ranges::iter_swap(__first1, __first2); ranges::iter_swap(__first1, __first2);
++__first1; ++__first1;
++__first2; ++__first2;
} }
return {_VSTD::move(__first1), _VSTD::move(__first2)}; return {_VSTD::move(__first1), _VSTD::move(__first2)};
philnikUnsubmitted
Not Done
ReplyInline Actions

You can replace _VSTD with std if you want to in this patch.

philnik: You can replace `_VSTD` with `std` if you want to in this patch.
jloserAuthorUnsubmitted
Done
ReplyInline Actions

Nah, I think that we should s/_VSTD/std in all of ranges in one patch if we're going to do that.

jloser: Nah, I think that we should `s/_VSTD/std` in all of ranges in one patch if we're going to do…
philnikUnsubmitted
Not Done
ReplyInline Actions

Right, I wanted to make a PR for that 😄 . Thanks for reminding me.

philnik: Right, I wanted to make a PR for that 😄 . Thanks for reminding me.
} }
template <input_range _R1, input_range _R2> template <input_range _R1, input_range _R2>
requires indirectly_swappable<iterator_t<_R1>, iterator_t<_R2>> requires indirectly_swappable<iterator_t<_R1>, iterator_t<_R2>>
_LIBCPP_HIDE_FROM_ABI constexpr _LIBCPP_HIDE_FROM_ABI constexpr
swap_ranges_result<borrowed_iterator_t<_R1>, borrowed_iterator_t<_R2>> swap_ranges_result<borrowed_iterator_t<_R1>, borrowed_iterator_t<_R2>>
operator()(_R1&& __r1, _R2&& __r2) const { operator()(_R1&& __r1, _R2&& __r2) const {
return operator()(ranges::begin(__r1), ranges::end(__r1), return operator()(ranges::begin(__r1), ranges::end(__r1),
Show All 15 Lines