This is an archive of the discontinued LLVM Phabricator instance.

Differential D119474

[ThinLTO][WPD] LICM set lookup (NFC)
ClosedPublic

Authored by tejohnson on Feb 10 2022, 12:43 PM.

Details

Reviewers
mingmingl
Commits
rGdd3f48333538: [ThinLTO][WPD] LICM set lookup (NFC)
Summary

Minor efficiency fix. There is no reason to perform the same set lookup
repeatedly in the inner loop as it is invariant there.

Diff Detail

Event Timeline

tejohnson created this revision.Feb 10 2022, 12:43 PM
Herald added subscribers: ormris, hiraditya, inglorion. · View Herald TranscriptFeb 10 2022, 12:43 PM
tejohnson requested review of this revision.Feb 10 2022, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 12:43 PM
mingmingl accepted this revision.Feb 10 2022, 1:14 PM
This revision is now accepted and ready to land.Feb 10 2022, 1:14 PM
This revision was landed with ongoing or failed builds.Feb 10 2022, 1:16 PM
Closed by commit rGdd3f48333538: [ThinLTO][WPD] LICM set lookup (NFC) (authored by tejohnson). · Explain Why
This revision was automatically updated to reflect the committed changes.
tejohnson added a commit: rGdd3f48333538: [ThinLTO][WPD] LICM set lookup (NFC).
Harbormaster completed remote builds in B148823: Diff 407647.Feb 10 2022, 2:02 PM

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
9 lines

Diff 407660

llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp

Show First 20 Lines • Show All 860 Lines • ▼ Show 20 Lines
/// visibility metadata on vtable definition summaries to linkage unit /// visibility metadata on vtable definition summaries to linkage unit
/// visibility in Module summary index (for ThinLTO). /// visibility in Module summary index (for ThinLTO).
void updateVCallVisibilityInIndex( void updateVCallVisibilityInIndex(
ModuleSummaryIndex &Index, bool WholeProgramVisibilityEnabledInLTO, ModuleSummaryIndex &Index, bool WholeProgramVisibilityEnabledInLTO,
const DenseSet<GlobalValue::GUID> &DynamicExportSymbols) { const DenseSet<GlobalValue::GUID> &DynamicExportSymbols) {
if (!hasWholeProgramVisibility(WholeProgramVisibilityEnabledInLTO)) if (!hasWholeProgramVisibility(WholeProgramVisibilityEnabledInLTO))
return; return;
for (auto &P : Index) { for (auto &P : Index) {
// Don't upgrade the visibility for symbols exported to the dynamic
// linker, as we have no information on their eventual use.
if (DynamicExportSymbols.count(P.first))
continue;
for (auto &S : P.second.SummaryList) { for (auto &S : P.second.SummaryList) {
auto *GVar = dyn_cast<GlobalVarSummary>(S.get()); auto *GVar = dyn_cast<GlobalVarSummary>(S.get());
if (!GVar || if (!GVar ||
GVar->getVCallVisibility() != GlobalObject::VCallVisibilityPublic || GVar->getVCallVisibility() != GlobalObject::VCallVisibilityPublic)
// Don't upgrade the visibility for symbols exported to the dynamic
// linker, as we have no information on their eventual use.
DynamicExportSymbols.count(P.first))
continue; continue;
GVar->setVCallVisibility(GlobalObject::VCallVisibilityLinkageUnit); GVar->setVCallVisibility(GlobalObject::VCallVisibilityLinkageUnit);
} }
} }
} }
void runWholeProgramDevirtOnIndex( void runWholeProgramDevirtOnIndex(
ModuleSummaryIndex &Summary, std::set<GlobalValue::GUID> &ExportedGUIDs, ModuleSummaryIndex &Summary, std::set<GlobalValue::GUID> &ExportedGUIDs,
▲ Show 20 Lines • Show All 1,487 Lines • Show Last 20 Lines