Page MenuHomePhabricator

[AVR] Fix a potential assert failure
ClosedPublic

Authored by benshi001 on Feb 10 2022, 1:31 AM.

Diff Detail

Event Timeline

benshi001 created this revision.Feb 10 2022, 1:31 AM
benshi001 requested review of this revision.Feb 10 2022, 1:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 1:31 AM
benshi001 updated this revision to Diff 407420.Feb 10 2022, 1:36 AM
benshi001 edited the summary of this revision. (Show Details)

Actually the variable F is no longer used, even as argument in the call of analyzeArguments(&CLI, F, &DAG.getDataLayout(), Outs, ArgLocs, CCInfo);.

I think we should keep it if there will be further use in the future.

At least it fixes https://github.com/llvm/llvm-project/issues/43443 .

MaskRay accepted this revision.Feb 10 2022, 2:12 PM

Looks great!

llvm/test/CodeGen/AVR/issue-43443-ctor-alias.ll
1 ↗(On Diff #407420)

you can rename this pr43443-ctor-alias.ll

4 ↗(On Diff #407420)

Consider ;;

; comments sometimes may be stripped by utils/update_llc_test_checks.py

This revision is now accepted and ready to land.Feb 10 2022, 2:12 PM
benshi001 marked 2 inline comments as done.Feb 10 2022, 5:22 PM
benshi001 added inline comments.
llvm/test/CodeGen/AVR/issue-43443-ctor-alias.ll
1 ↗(On Diff #407420)

I will change the file name and adopt ;; when commiting. Thanks for your comments !!

This revision was landed with ongoing or failed builds.Feb 10 2022, 6:26 PM
This revision was automatically updated to reflect the committed changes.
benshi001 marked an inline comment as done.