This is an archive of the discontinued LLVM Phabricator instance.

Differential D119353

[libunwind] Avoid a warning in 32 bit builds. NFC.
ClosedPublic

Authored by mstorsjo on Feb 9 2022, 9:38 AM.

Details

Reviewers
MaskRay
phosek
Group Reviewers
Restricted Project
Commits
rGdfa5ab7b2b51: [libunwind] Avoid a warning in 32 bit builds. NFC.
Summary

The warning was introduced with the recently merged SPARCv9
support. The cast matches the existing surrounding cases.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 9 2022, 9:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 9:38 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: fedor.sergeev, jyknight. · View Herald Transcript
mstorsjo requested review of this revision.Feb 9 2022, 9:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 9:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
phosek accepted this revision.Feb 9 2022, 9:53 AM
phosek added a subscriber: phosek.

LGTM

This revision is now accepted and ready to land.Feb 9 2022, 9:53 AM
This revision was landed with ongoing or failed builds.Feb 9 2022, 1:01 PM
Closed by commit rGdfa5ab7b2b51: [libunwind] Avoid a warning in 32 bit builds. NFC. (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGdfa5ab7b2b51: [libunwind] Avoid a warning in 32 bit builds. NFC..
Harbormaster completed remote builds in B148505: Diff 407192.Feb 9 2022, 1:15 PM
MaskRay added a comment.Feb 9 2022, 1:55 PM

Thanks! cherry picked into release/14.x

Revision Contents

PathSize
libunwind/
src/
4 lines

Diff 407258

libunwind/src/DwarfInstructions.hpp

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines
typename A::pint_t DwarfInstructions<A, R>::getSavedRegister( typename A::pint_t DwarfInstructions<A, R>::getSavedRegister(
A &addressSpace, const R &registers, pint_t cfa, A &addressSpace, const R &registers, pint_t cfa,
const RegisterLocation &savedReg) { const RegisterLocation &savedReg) {
switch (savedReg.location) { switch (savedReg.location) {
case CFI_Parser<A>::kRegisterInCFA: case CFI_Parser<A>::kRegisterInCFA:
return (pint_t)addressSpace.getRegister(cfa + (pint_t)savedReg.value); return (pint_t)addressSpace.getRegister(cfa + (pint_t)savedReg.value);
case CFI_Parser<A>::kRegisterInCFADecrypt: // sparc64 specific case CFI_Parser<A>::kRegisterInCFADecrypt: // sparc64 specific
return addressSpace.getP(cfa + (pint_t)savedReg.value) ^ return (pint_t)(addressSpace.getP(cfa + (pint_t)savedReg.value) ^
getSparcWCookie(registers, 0); getSparcWCookie(registers, 0));
case CFI_Parser<A>::kRegisterAtExpression: case CFI_Parser<A>::kRegisterAtExpression:
return (pint_t)addressSpace.getRegister(evaluateExpression( return (pint_t)addressSpace.getRegister(evaluateExpression(
(pint_t)savedReg.value, addressSpace, registers, cfa)); (pint_t)savedReg.value, addressSpace, registers, cfa));
case CFI_Parser<A>::kRegisterIsExpression: case CFI_Parser<A>::kRegisterIsExpression:
return evaluateExpression((pint_t)savedReg.value, addressSpace, return evaluateExpression((pint_t)savedReg.value, addressSpace,
registers, cfa); registers, cfa);
▲ Show 20 Lines • Show All 768 Lines • Show Last 20 Lines