Deleted old fixme.

[rsmith]

Reid, do you remember what this FIXME was for? (Added in r198462.)

[rnk]

I added this code before C++11 migration. I wanted to explicitly default the copy ctor to document that it's a value type, rather than defaulting it implicitly. You can nuke both comments and uncomment the definition.

[rsmith]

This change now disables the move constructor and move assignment. I think just removing the comment is better.

[rnk]

include/clang/AST/VTableBuilder.h

54

Is this ctor used? It leaves Value uninitialized. Maybe we should delete it to ensure that it isn't called, or use a default member initializer for Value below.

[Prazek]

include/clang/AST/VTableBuilder.h

54

it is required, f.e.:

VTableComponents(new VTableComponent[NumVTableComponents]),

[nwilson]

Hi Piotr,

Would you mind renaming the title of the Patch since the title will be
committed as such?

Thanks!

[rnk]

lgtm

include/clang/AST/VTableBuilder.h

enum Kind {
     /// \brief An entry that is never used.
     ///
     /// In some cases, a vtable function pointer will end up never being
     /// called. Such vtable function pointers are represented as a
     /// CK_UnusedFunctionPointer.
     CK_UnusedFunctionPointer
   };
 
-  VTableComponent() { }
+  VTableComponent() = default;
 
   static VTableComponent MakeVCallOffset(CharUnits Offset) {
     return VTableComponent(CK_VCallOffset, Offset);
   }
 
   static VTableComponent MakeVBaseOffset(CharUnits Offset) {
     return VTableComponent(CK_VBaseOffset, Offset);
   }

 /// table pointer.  A record may contain as many vfptrs or vbptrs as there are
 /// base subobjects.
 struct VPtrInfo {
   typedef SmallVector<const CXXRecordDecl *, 1> BasePath;
 
   VPtrInfo(const CXXRecordDecl *RD)
       : ReusingBase(RD), BaseWithVPtr(RD), NextBaseToMangle(RD) {}
 
-  // Copy constructor.
-  // FIXME: Uncomment when we've moved to C++11.
-  // VPtrInfo(const VPtrInfo &) = default;
-
+  VPtrInfo(const VPtrInfo &) = default;
   /// The vtable will hold all of the virtual bases or virtual methods of
   /// ReusingBase.  This may or may not be the same class as VPtrSubobject.Base.
   /// A derived class will reuse the vptr of the first non-virtual base
   /// subobject that has one.
   const CXXRecordDecl *ReusingBase;
 
   /// BaseWithVPtr is at this offset from its containing complete object or
   /// virtual base.