Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Driver/ToolChains/Fuchsia.cpp | ||
---|---|---|
129–130 | I think all these runtime additions need to be conditional. There must be no kinds of implicit link inputs at all when using -nostdlib. |
clang/lib/Driver/ToolChains/Fuchsia.cpp | ||
---|---|---|
153–156 | This function is a no-op because it tests for fuchsia targets. So it probably makes more sense not to call it and to remove its fuchsia special-case. |
Have you checked if all the tests are still passing?
clang/lib/Driver/ToolChains/Fuchsia.cpp | ||
---|---|---|
162 | This shouldn't move, these are linker inputs provided by the used and should be always passed to the linker. |
All the clang tests seem to be passing, but I'll run the llvm and runtimes tests also.
LGTM
clang/lib/Driver/ToolChains/Fuchsia.cpp | ||
---|---|---|
158–160 | I think this can be dropped as well. |
I think all these runtime additions need to be conditional. There must be no kinds of implicit link inputs at all when using -nostdlib.
I'm not sure what matters or doesn't wrt their relative order vs AddLinkerInputs.