This is an archive of the discontinued LLVM Phabricator instance.

Differential D119182

[Bitstream] Temporarily disable UBSan for invalid bitcode tests. This fixes failing sanitizer buildbots.
ClosedPublic

Authored by browneee on Feb 7 2022, 12:45 PM.

Details

Reviewers
vitalybuka
nikic
Commits
rG77f5a3fbba7a: [Bitstream] Temporarily disable UBSan for invalid bitcode tests. This fixes…
Summary

Tests added by

https://github.com/llvm/llvm-project/commit/3c86642edd28f1ce970882edaba8dce468ec7401
https://github.com/llvm/llvm-project/commit/f4fca0fbb052e55935b483c8955c440b59511ce8

cause existing code to exhibit UB:

https://github.com/llvm/llvm-project/blob/b4c6d1bb379192cb5b712fda9f60cd105f21194f/llvm/include/llvm/Bitstream/BitstreamReader.h#L244

llvm/include/llvm/Bitstream/BitstreamReader.h:244:51:
runtime error: shift exponent 35 is too large for 32-bit type 'unsigned int'

Hitting the UBSan error before the expected error causes the test to fail under UBSan:

Diff Detail

Unit TestsFailed

TimeTest
60,100 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,150 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c
60,220 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c
60,180 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vloxseg.c
60,200 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vluxseg.c
View Full Test Results (9 Failed)

Event Timeline

browneee requested review of this revision.Feb 7 2022, 12:45 PM
browneee created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 12:45 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
browneee added reviewers: vitalybuka, nikic.Feb 7 2022, 1:43 PM
vitalybuka accepted this revision.Feb 7 2022, 1:51 PM
vitalybuka added inline comments.
llvm/test/Bitcode/invalid-no-ubsan.test
11–19

Please don't move lines unnecessary

This revision is now accepted and ready to land.Feb 7 2022, 1:51 PM
browneee added inline comments.Feb 7 2022, 1:54 PM
llvm/test/Bitcode/invalid-no-ubsan.test
11–19

Do you mean do not move these lines into a different file?

Then UNSUPPORTED: ubsan would disable all of the other tests that do work under UBSan. That could allow more UB to enter.

This revision was landed with ongoing or failed builds.Feb 7 2022, 1:56 PM
Closed by commit rG77f5a3fbba7a: [Bitstream] Temporarily disable UBSan for invalid bitcode tests. This fixes… (authored by browneee). · Explain Why
This revision was automatically updated to reflect the committed changes.
browneee added a commit: rG77f5a3fbba7a: [Bitstream] Temporarily disable UBSan for invalid bitcode tests. This fixes….
Harbormaster completed remote builds in B148079: Diff 406578.Feb 7 2022, 4:59 PM
jkorous mentioned this in D119307: [Bitstream] Fix UB in left-shift in ReadVBR.Feb 8 2022, 6:15 PM

Revision Contents

PathSize
llvm/
test/
Bitcode/
19 lines
10 lines

Diff 406578

llvm/test/Bitcode/invalid-no-ubsan.test

  • This file was added.
# These tests cover invalid inputs.
# When running under UBSan these tests hit UBSan issues before the validity
# checks that the test is intending to exercise.
# Under UBSan these tests fail because UBSan error is not the expected error.
#
# TODO: This code should be fixed to not exhibit UB, and these tests should be
# incorporated back into invalid.test and run under UBSan again.
UNSUPPORTED: ubsan
RUN: not llvm-dis -disable-output %p/Inputs/size-not-plausible.bc 2>&1 | \
RUN: FileCheck --check-prefix=SIZE-NOT-PLAUSIBLE %s
SIZE-NOT-PLAUSIBLE: Size is not plausible
RUN: not llvm-dis -disable-output %p/Inputs/invalid-value-symbol-table-2.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-VALUE-SYMBOL-TABLE-2 %s
INVALID-VALUE-SYMBOL-TABLE-2: Expected value symbol table subbloc
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

Please don't move lines unnecessary

vitalybuka: Please don't move lines unnecessary
browneeeAuthorUnsubmitted
Done
ReplyInline Actions

Do you mean do not move these lines into a different file?

Then UNSUPPORTED: ubsan would disable all of the other tests that do work under UBSan. That could allow more UB to enter.

browneee: Do you mean do not move these lines into a different file? Then `UNSUPPORTED: ubsan` would…

llvm/test/Bitcode/invalid.test

Show First 20 Lines • Show All 246 Lines • ▼ Show 20 Lines
CMPXCHG-ORDERING: Invalid cmpxchg {{failure|success}} ordering CMPXCHG-ORDERING: Invalid cmpxchg {{failure|success}} ordering
RUN: not llvm-dis -disable-output %p/Inputs/invalid-abbrev-number.bc 2>&1 | \ RUN: not llvm-dis -disable-output %p/Inputs/invalid-abbrev-number.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-ABBREV-NUMBER %s RUN: FileCheck --check-prefix=INVALID-ABBREV-NUMBER %s
INVALID-ABBREV-NUMBER: Invalid abbrev number INVALID-ABBREV-NUMBER: Invalid abbrev number
RUN: not llvm-dis -disable-output %p/Inputs/size-not-plausible.bc 2>&1 | \
RUN: FileCheck --check-prefix=SIZE-NOT-PLAUSIBLE %s
SIZE-NOT-PLAUSIBLE: Size is not plausible
RUN: not llvm-dis -disable-output %p/Inputs/invalid-attribute-group-entry.bc 2>&1 | \ RUN: not llvm-dis -disable-output %p/Inputs/invalid-attribute-group-entry.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-ATTRIBUTE-GROUP-ENTRY %s RUN: FileCheck --check-prefix=INVALID-ATTRIBUTE-GROUP-ENTRY %s
INVALID-ATTRIBUTE-GROUP-ENTRY: Invalid attribute group entry INVALID-ATTRIBUTE-GROUP-ENTRY: Invalid attribute group entry
RUN: not llvm-dis -disable-output %p/Inputs/unterminated-blob.bc 2>&1 | \ RUN: not llvm-dis -disable-output %p/Inputs/unterminated-blob.bc 2>&1 | \
RUN: FileCheck --check-prefix=UNTERMINATED-BLOB %s RUN: FileCheck --check-prefix=UNTERMINATED-BLOB %s
UNTERMINATED-BLOB: Blob ends too soon UNTERMINATED-BLOB: Blob ends too soon
RUN: not llvm-dis -disable-output %p/Inputs/invalid-value-symbol-table.bc 2>&1 | \ RUN: not llvm-dis -disable-output %p/Inputs/invalid-value-symbol-table.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-VALUE-SYMBOL-TABLE %s RUN: FileCheck --check-prefix=INVALID-VALUE-SYMBOL-TABLE %s
INVALID-VALUE-SYMBOL-TABLE: Invalid value reference in symbol table INVALID-VALUE-SYMBOL-TABLE: Invalid value reference in symbol table
RUN: not llvm-dis -disable-output %p/Inputs/invalid-value-symbol-table-2.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-VALUE-SYMBOL-TABLE-2 %s
INVALID-VALUE-SYMBOL-TABLE-2: Expected value symbol table subblock