This is an archive of the discontinued LLVM Phabricator instance.

Differential D119140

[libc++] Disable -Wattributes in GCC
ClosedPublic

Authored by philnik on Feb 7 2022, 7:10 AM.

Details

Reviewers
ldionne
• Quuxplusone
Group Reviewers
Restricted Project
Commits
rG0e7d7fe9122c: [libc++] Disable -Wattributes in GCC
Summary

Currently GCC produces lots of warnings. Most of them are -Wattributes, but these warnings are completly ignored by everybody. So let's disable -Wattributes and make the output cleaner.

Diff Detail

Event Timeline

philnik created this revision.Feb 7 2022, 7:10 AM
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 7 2022, 7:10 AM
philnik requested review of this revision.Feb 7 2022, 7:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 7:10 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne accepted this revision.Feb 7 2022, 8:22 AM
This revision is now accepted and ready to land.Feb 7 2022, 8:22 AM
Harbormaster completed remote builds in B147980: Diff 406453.Feb 7 2022, 8:30 AM
Closed by commit rG0e7d7fe9122c: [libc++] Disable -Wattributes in GCC (authored by philnik). · Explain WhyFeb 7 2022, 11:00 AM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG0e7d7fe9122c: [libc++] Disable -Wattributes in GCC.

Revision Contents

PathSize
libcxx/
1 line

Diff 406453

libcxx/CMakeLists.txt

Show First 20 Lines • Show All 617 Lines • ▼ Show 20 Lines if (LIBCXX_TARGETING_CLANG_CL)
-Wno-old-style-cast -Wno-old-style-cast
-Wno-deprecated # FIXME: Remove this and fix all occurrences. -Wno-deprecated # FIXME: Remove this and fix all occurrences.
-Wno-shift-sign-overflow # FIXME: Why do we need this with clang-cl but not clang? -Wno-shift-sign-overflow # FIXME: Why do we need this with clang-cl but not clang?
-Wno-double-promotion # FIXME: remove me -Wno-double-promotion # FIXME: remove me
) )
endif() endif()
elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")
target_add_compile_flags_if_supported(${target} PRIVATE target_add_compile_flags_if_supported(${target} PRIVATE
-Wno-attributes
-Wno-literal-suffix -Wno-literal-suffix
-Wno-c++14-compat -Wno-c++14-compat
-Wno-noexcept-type -Wno-noexcept-type
-Wno-suggest-override) -Wno-suggest-override)
endif() endif()
if (LIBCXX_ENABLE_WERROR) if (LIBCXX_ENABLE_WERROR)
target_add_compile_flags_if_supported(${target} PRIVATE -Werror) target_add_compile_flags_if_supported(${target} PRIVATE -Werror)
target_add_compile_flags_if_supported(${target} PRIVATE -WX) target_add_compile_flags_if_supported(${target} PRIVATE -WX)
▲ Show 20 Lines • Show All 351 Lines • Show Last 20 Lines