Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D118970

[msan] Guard FP_XSTATE_MAGIC1 usage with SANITIZER_GLIBC
ClosedPublic
Actions

Authored by MaskRay on Feb 3 2022, 10:51 PM.

Details

Reviewers
dvyukov
vitalybuka
Group Reviewers
Restricted Project
Commits
rG9d1857f69f4e: [msan] Guard FP_XSTATE_MAGIC1 usage with SANITIZER_GLIBC
Summary

Fix build for Linux musl.

Diff Detail

Event Timeline

MaskRay requested review of this revision.Feb 3 2022, 10:51 PM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2022, 10:51 PM
Harbormaster completed remote builds in B147567: Diff 405874.Feb 3 2022, 11:10 PM
dvyukov accepted this revision.Feb 4 2022, 1:14 AM
dvyukov added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp
220

SANITIZER_GLIBC implies LINUX, right?

This revision is now accepted and ready to land.Feb 4 2022, 1:14 AM
Closed by commit rG9d1857f69f4e: [msan] Guard FP_XSTATE_MAGIC1 usage with SANITIZER_GLIBC (authored by MaskRay). · Explain WhyFeb 4 2022, 10:15 AM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG9d1857f69f4e: [msan] Guard FP_XSTATE_MAGIC1 usage with SANITIZER_GLIBC.
MaskRay marked an inline comment as done.Feb 4 2022, 11:30 AM
MaskRay added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp
220

Yes. We don't support GNU Hurd.

vchuravy mentioned this in D124770: [Sanitizers] Guard FP_XSTATE_MAGIC1 usage by GLIBC version.May 2 2022, 7:07 AM

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines
test/
msan/
Linux/
2 lines
3 lines

Diff 406028

View Options

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp

Loading...
View Options

compiler-rt/test/msan/Linux/signal_mcontext.cpp

Loading...
View Options

compiler-rt/test/msan/Linux/signal_mcontext2.cpp

Loading...