Page MenuHomePhabricator

[Sanitizers] Guard FP_XSTATE_MAGIC1 usage by GLIBC version
Needs RevisionPublic

Authored by vchuravy on May 2 2022, 7:07 AM.

Details

Reviewers
MaskRay
Summary

Follow-up on https://reviews.llvm.org/D118970 FP_XSTATE_MAGIC1 is only available on glibc 2.27 and upwards

Diff Detail

Event Timeline

vchuravy created this revision.May 2 2022, 7:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2022, 7:07 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
vchuravy requested review of this revision.May 2 2022, 7:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2022, 7:07 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vchuravy added a subscriber: Restricted Project.May 2 2022, 7:54 AM
MaskRay requested changes to this revision.May 21 2022, 2:52 PM

FP_XSTATE_MAGIC1 is only available on glibc 2.27 and upwards

Please make some verification before making a claim. The macro is defined in sysdeps/unix/sysv/linux/x86/bits/sigcontext.h in glibc's release/2.16/master branch.

commit 14adcbfc36fbec33594635a8d93834149cb8a8fa
Author: H.J. Lu
Date:   Mon Jun 4 12:40:46 2012

    Update x86_64 bits/sigcontext.h from kernel 3.4.0

I am not sure we want to support pre-2.16 systems.

This revision now requires changes to proceed.May 21 2022, 2:52 PM