This is an archive of the discontinued LLVM Phabricator instance.

Differential D118961

[mte] fix runOnFunction return value falsely suggesting function was modified.
ClosedPublic

Authored by fmayer on Feb 3 2022, 6:21 PM.

Details

Reviewers
eugenis
Commits
rG3918dd6b8acf: [mte] fix runOnFunction return value falsely suggesting function was modified.
Summary

If NumInterestingAllocas == 0 we do not add any instrumentation or
padding in the previous loop.

Diff Detail

Event Timeline

fmayer created this revision.Feb 3 2022, 6:21 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptFeb 3 2022, 6:21 PM
fmayer requested review of this revision.Feb 3 2022, 6:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2022, 6:21 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fmayer added a child revision: D118960: [mte] [nfc] do not keep Tag in AllocaInfo.Feb 3 2022, 6:23 PM
fmayer added a reviewer: eugenis.
Harbormaster completed remote builds in B147546: Diff 405849.Feb 3 2022, 7:02 PM
eugenis accepted this revision.Feb 4 2022, 10:32 AM

LGTM

This revision is now accepted and ready to land.Feb 4 2022, 10:32 AM
This revision was landed with ongoing or failed builds.Feb 4 2022, 10:34 AM
Closed by commit rG3918dd6b8acf: [mte] fix runOnFunction return value falsely suggesting function was modified. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG3918dd6b8acf: [mte] fix runOnFunction return value falsely suggesting function was modified..

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
2 lines

Diff 405849

llvm/lib/Target/AArch64/AArch64StackTagging.cpp

Show First 20 Lines • Show All 599 Lines • ▼ Show 20 Lines for (auto &I : Allocas) {
alignAndPadAlloca(Info); alignAndPadAlloca(Info);
NumInterestingAllocas++; NumInterestingAllocas++;
Info.Tag = NextTag; Info.Tag = NextTag;
NextTag = (NextTag + 1) % 16; NextTag = (NextTag + 1) % 16;
} }
if (NumInterestingAllocas == 0) if (NumInterestingAllocas == 0)
return true; return false;
std::unique_ptr<DominatorTree> DeleteDT; std::unique_ptr<DominatorTree> DeleteDT;
DominatorTree *DT = nullptr; DominatorTree *DT = nullptr;
if (auto *P = getAnalysisIfAvailable<DominatorTreeWrapperPass>()) if (auto *P = getAnalysisIfAvailable<DominatorTreeWrapperPass>())
DT = &P->getDomTree(); DT = &P->getDomTree();
if (DT == nullptr && (NumInterestingAllocas > 1 || if (DT == nullptr && (NumInterestingAllocas > 1 ||
!F->hasFnAttribute(Attribute::OptimizeNone))) { !F->hasFnAttribute(Attribute::OptimizeNone))) {
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines