Details
Details
- Reviewers
philnik - Group Reviewers
Restricted Project - Commits
- rGc292b6066cca: [libc++] Implement P1007R3: std::assume_aligned
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I believe so, because we don't use __builtin_assume_aligned during constant evaluation anymore, and that was the main holdup IIUC.
libcxx/test/std/utilities/memory/ptr.align/assume_aligned.nodiscard.verify.cpp | ||
---|---|---|
21 | Not sure, removed. |
Comment Actions
LGTM % nit
libcxx/include/__memory/assume_aligned.h | ||
---|---|---|
38 | I think I'd like a reinterpret_cast here a bit more. At least say that you're an evil person. |
Comment Actions
Applied @philnik's comment locally. The test failure is a fluke, so I'll ignore it. Shipping this!
I think I'd like a reinterpret_cast here a bit more. At least say that you're an evil person.