[asan][test] Re-generate asan-check-memaccess-add.ll with update_llc_test_checks.py

[MaskRay]

Summary

• LABEL is important to give a better diagnostic in case a check pattern fails
• Some NOT negative patterns are not effective. NEXT is useful to ensure a code sequence has the desired instructions and report a better diagnostic if something goes off.
• Since the ABI says the first parameter is in RDI. Replacing the pattern [[REG16:.*]] with RDI should not cause maintenance burden.

Since the test is pretty mechanical, just use update_llc_test_checks.py
to re-generate it. Most functions can use nounwind to avoid CFI
directives.

[kstoimenov]

llvm/test/CodeGen/X86/asan-check-memaccess-add.ll

6–7

The 'nounwind' is missing for load1. Was that intentional?

[MaskRay]

llvm/test/CodeGen/X86/asan-check-memaccess-add.ll

6–7

Yes. To have a test for .cfi_def_cfa_offset 16 ...

[kstoimenov]

LGTM

llvm/test/CodeGen/X86/asan-check-memaccess-add.ll

+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s | FileCheck %s
 
 target triple = "x86_64-unknown-linux-gnu"
 
 define void @load1(i8* nocapture readonly %x) {
-; CHECK:              pushq   %rax
-; CHECK-NOT:          push    %rbp
-; CHECK:              callq   __asan_check_load_add_1_[[REG1:.*]]
-; CHECK:              callq   __asan_check_store_add_1_[[REG1]]
-; CHECK-NOT:          pop     %rbp
-; CHECK:              popq    %rax
+; CHECK-LABEL: load1:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    pushq %rax
+; CHECK-NEXT:    .cfi_def_cfa_offset 16
+; CHECK-NEXT:    callq __asan_check_load_add_1_RDI
+; CHECK-NEXT:    callq __asan_check_store_add_1_RDI
+; CHECK-NEXT:    popq %rax
+; CHECK-NEXT:    .cfi_def_cfa_offset 8
+; CHECK-NEXT:    retq
   call void @llvm.asan.check.memaccess(i8* %x, i32 0)
   call void @llvm.asan.check.memaccess(i8* %x, i32 32)
   ret void
 }
 
-define void @load2(i16* nocapture readonly %x) {
-; CHECK:              pushq   %rax
-; CHECK-NOT:          push    %rbp
-; CHECK:              callq   __asan_check_load_add_2_[[REG2:.*]]
-; CHECK:              callq   __asan_check_store_add_2_[[REG2]]
-; CHECK-NOT:          pop     %rbp
-; CHECK:              popq    %rax
+define void @load2(i16* nocapture readonly %x) nounwind {
+; CHECK-LABEL: load2:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    pushq %rax
+; CHECK-NEXT:    callq __asan_check_load_add_2_RDI
+; CHECK-NEXT:    callq __asan_check_store_add_2_RDI
+; CHECK-NEXT:    popq %rax
+; CHECK-NEXT:    retq
   %1 = ptrtoint i16* %x to i64
   %2 = bitcast i16* %x to i8*
   call void @llvm.asan.check.memaccess(i8* %2, i32 2)
   call void @llvm.asan.check.memaccess(i8* %2, i32 34)
   ret void
 }
 
-define void @load4(i32* nocapture readonly %x) {
-; CHECK:              pushq   %rax
-; CHECK-NOT:          push    %rbp
-; CHECK:              callq   __asan_check_load_add_4_[[REG4:.*]]
-; CHECK:              callq   __asan_check_store_add_4_[[REG4]]
-; CHECK-NOT:          pop     %rbp
-; CHECK:              popq    %rax
+define void @load4(i32* nocapture readonly %x) nounwind {
+; CHECK-LABEL: load4:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    pushq %rax
+; CHECK-NEXT:    callq __asan_check_load_add_4_RDI
+; CHECK-NEXT:    callq __asan_check_store_add_4_RDI
+; CHECK-NEXT:    popq %rax
+; CHECK-NEXT:    retq
   %1 = ptrtoint i32* %x to i64
   %2 = bitcast i32* %x to i8*
   call void @llvm.asan.check.memaccess(i8* %2, i32 4)
   call void @llvm.asan.check.memaccess(i8* %2, i32 36)
   ret void
 }
-define void @load8(i64* nocapture readonly %x) {
-; CHECK:              pushq   %rax
-; CHECK-NOT:          push    %rbp
-; CHECK:              callq   __asan_check_load_add_8_[[REG8:.*]]
-; CHECK:              callq   __asan_check_store_add_8_[[REG8]]
-; CHECK-NOT:          pop     %rbp
-; CHECK:              popq    %rax
+
+define void @load8(i64* nocapture readonly %x) nounwind {
+; CHECK-LABEL: load8:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    pushq %rax
+; CHECK-NEXT:    callq __asan_check_load_add_8_RDI
+; CHECK-NEXT:    callq __asan_check_store_add_8_RDI
+; CHECK-NEXT:    popq %rax
+; CHECK-NEXT:    retq
   %1 = ptrtoint i64* %x to i64
   %2 = bitcast i64* %x to i8*
   call void @llvm.asan.check.memaccess(i8* %2, i32 6)
   call void @llvm.asan.check.memaccess(i8* %2, i32 38)
   ret void
 }
 
-define void @load16(i128* nocapture readonly %x) {
-; CHECK:              pushq   %rax
-; CHECK-NOT:          push    %rbp
-; CHECK:              callq   __asan_check_load_add_16_[[REG16:.*]]
-; CHECK:              callq   __asan_check_store_add_16_[[REG16]]
-; CHECK-NOT:          pop     %rbp
-; CHECK:              popq    %rax
+define void @load16(i128* nocapture readonly %x) nounwind {
+; CHECK-LABEL: load16:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    pushq %rax
+; CHECK-NEXT:    callq __asan_check_load_add_16_RDI
+; CHECK-NEXT:    callq __asan_check_store_add_16_RDI
+; CHECK-NEXT:    popq %rax
+; CHECK-NEXT:    retq
   %1 = ptrtoint i128* %x to i64
   %2 = bitcast i128* %x to i8*
   call void @llvm.asan.check.memaccess(i8* %2, i32 8)
   call void @llvm.asan.check.memaccess(i8* %2, i32 40)
   ret void
 }
 
 declare void @llvm.asan.check.memaccess(i8*, i32 immarg)