This is an archive of the discontinued LLVM Phabricator instance.

Update mlir bazel build file with appropriate math header dependencies.
AbandonedPublic

Authored by cmtice on Feb 2 2022, 4:43 PM.

Details

Reviewers
GMNGeoffrey
Summary

There are some new mlir math depenencies on mlir/Dialect/Arithmetic/Utils/Utils.h and mlir/Interfaces/InferTypeOpInterface.h, which need to be reflected in the bazel build file.

Diff Detail

Event Timeline

cmtice created this revision.Feb 2 2022, 4:43 PM
cmtice requested review of this revision.Feb 2 2022, 4:43 PM

Looks like this was fixed in https://github.com/llvm/llvm-project/commit/4a6c9b5686. You also generally don't want to list headers in multiple places. Rather, have those things depend on targets providing that header (as was done in the linked commit).

cmtice abandoned this revision.Feb 2 2022, 5:00 PM

It looks like someone else fixed this issue while I was creating this patch: https://github.com/llvm/llvm-project/commit/4a6c9b5686.

So I'll abandon this one. :-)