This is an archive of the discontinued LLVM Phabricator instance.

[mte] fix compiler crash with musttail.
ClosedPublic

Authored by fmayer on Feb 2 2022, 3:39 PM.

Details

Summary

see D118852 for matching hwasan fix.

Diff Detail

Event Timeline

fmayer created this revision.Feb 2 2022, 3:39 PM
fmayer requested review of this revision.Feb 2 2022, 3:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 3:39 PM
fmayer updated this revision to Diff 405476.Feb 2 2022, 3:41 PM

simplify test

fmayer updated this revision to Diff 405479.Feb 2 2022, 3:51 PM

remove comments

eugenis accepted this revision.Feb 2 2022, 4:07 PM

LGTM

llvm/test/CodeGen/AArch64/stack-tagging-musttail.ll
21

It would be nice to check that settag goes before the musttail call. Also at least a brief comment about what is being tested for future maintainers ("regression test for a compiler crash ...")

This revision is now accepted and ready to land.Feb 2 2022, 4:07 PM
fmayer updated this revision to Diff 405489.Feb 2 2022, 4:12 PM

improve test

fmayer marked an inline comment as done.Feb 2 2022, 4:12 PM
This revision was landed with ongoing or failed builds.Feb 2 2022, 4:13 PM
This revision was automatically updated to reflect the committed changes.