This is an archive of the discontinued LLVM Phabricator instance.

Differential D118839

[compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia
ClosedPublic

Authored by mcgrathr on Feb 2 2022, 12:22 PM.

Details

Reviewers
phosek
abrachet
Commits
rG4e731abc5568: [compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia
Summary

Use Fuchsia's zx_system_get_features API to determine
whether LSE atomics are available on the machine.

Diff Detail

Event Timeline

mcgrathr created this revision.Feb 2 2022, 12:22 PM
Herald added subscribers: kristof.beyls, dberris. · View Herald TranscriptFeb 2 2022, 12:22 PM
mcgrathr requested review of this revision.Feb 2 2022, 12:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 12:22 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
abrachet accepted this revision.Feb 2 2022, 12:30 PM
This revision is now accepted and ready to land.Feb 2 2022, 12:30 PM
Harbormaster completed remote builds in B147225: Diff 405386.Feb 2 2022, 12:40 PM
abrachet added a comment.Mar 22 2022, 8:58 AM

Has this been committed yet?

Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 8:58 AM
This revision was landed with ongoing or failed builds.Mar 28 2022, 11:49 AM
Closed by commit rG4e731abc5568: [compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG4e731abc5568: [compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
11 lines

Diff 418667

compiler-rt/lib/builtins/cpu_model.c

Show First 20 Lines • Show All 795 Lines • ▼ Show 20 Lines
#define AT_HWCAP 16 #define AT_HWCAP 16
#endif #endif
#ifndef HWCAP_ATOMICS #ifndef HWCAP_ATOMICS
#define HWCAP_ATOMICS (1 << 8) #define HWCAP_ATOMICS (1 << 8)
#endif #endif
#if defined(__ANDROID__) #if defined(__ANDROID__)
#include <string.h> #include <string.h>
#include <sys/system_properties.h> #include <sys/system_properties.h>
#elif defined(__Fuchsia__)
#include <zircon/features.h>
#include <zircon/syscalls.h>
#endif #endif
static void CONSTRUCTOR_ATTRIBUTE init_have_lse_atomics(void) { static void CONSTRUCTOR_ATTRIBUTE init_have_lse_atomics(void) {
#if defined(__FreeBSD__) #if defined(__FreeBSD__)
unsigned long hwcap; unsigned long hwcap;
int result = elf_aux_info(AT_HWCAP, &hwcap, sizeof hwcap); int result = elf_aux_info(AT_HWCAP, &hwcap, sizeof hwcap);
__aarch64_have_lse_atomics = result == 0 && (hwcap & HWCAP_ATOMICS) != 0; __aarch64_have_lse_atomics = result == 0 && (hwcap & HWCAP_ATOMICS) != 0;
#elif defined(__Fuchsia__)
// This ensures the vDSO is a direct link-time dependency of anything that
// needs this initializer code.
#pragma comment(lib, "zircon")
uint32_t features;
zx_status_t status = _zx_system_get_features(ZX_FEATURE_KIND_CPU, &features);
__aarch64_have_lse_atomics =
status == ZX_OK && (features & ZX_ARM64_FEATURE_ISA_ATOMICS) != 0;
#else #else
unsigned long hwcap = getauxval(AT_HWCAP); unsigned long hwcap = getauxval(AT_HWCAP);
_Bool result = (hwcap & HWCAP_ATOMICS) != 0; _Bool result = (hwcap & HWCAP_ATOMICS) != 0;
#if defined(__ANDROID__) #if defined(__ANDROID__)
if (result) { if (result) {
char arch[PROP_VALUE_MAX]; char arch[PROP_VALUE_MAX];
if (__system_property_get("ro.arch", arch) > 0 && if (__system_property_get("ro.arch", arch) > 0 &&
strncmp(arch, "exynos9810", sizeof("exynos9810") - 1) == 0) { strncmp(arch, "exynos9810", sizeof("exynos9810") - 1) == 0) {
Show All 19 Lines