This is an archive of the discontinued LLVM Phabricator instance.

Differential D118721

[flang] Fix argument keyword names in some specific intrinsics
ClosedPublic

Authored by klausler on Feb 1 2022, 11:59 AM.

Details

Reviewers
PeteSteinfeld
Commits
rG01b52f77c95c: [flang] Fix argument keyword names in some specific intrinsics
Summary

Some entries in the specific intrinsic function table have the
wrong argument keyword names -- they should agree with the names
of the arguments on their corresponding generic intrinsic function.
Clean them up.

Diff Detail

Event Timeline

klausler created this revision.Feb 1 2022, 11:59 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptFeb 1 2022, 11:59 AM
klausler requested review of this revision.Feb 1 2022, 11:59 AM
PeteSteinfeld accepted this revision.Feb 1 2022, 12:36 PM

Thanks for picking through the details on this.

All looks good.

This revision is now accepted and ready to land.Feb 1 2022, 12:36 PM
Harbormaster completed remote builds in B146968: Diff 405028.Feb 1 2022, 1:19 PM
Closed by commit rG01b52f77c95c: [flang] Fix argument keyword names in some specific intrinsics (authored by klausler). · Explain WhyFeb 1 2022, 4:55 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG01b52f77c95c: [flang] Fix argument keyword names in some specific intrinsics.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2022, 4:55 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
flang/
lib/
Evaluate/
32 lines

Diff 405028

flang/lib/Evaluate/intrinsics.cpp

Context not available.
TypePattern{IntType, KindCode::exactKind, 1}}, TypePattern{IntType, KindCode::exactKind, 1}},
"abs"}, "abs"},
{{"cabs", {{"a", DefaultComplex}}, DefaultReal}, "abs"}, {{"cabs", {{"a", DefaultComplex}}, DefaultReal}, "abs"},
{{"ccos", {{"a", DefaultComplex}}, DefaultComplex}, "cos"}, {{"ccos", {{"x", DefaultComplex}}, DefaultComplex}, "cos"},
{{"cdabs", {{"a", DoublePrecisionComplex}}, DoublePrecision}, "abs"}, {{"cdabs", {{"a", DoublePrecisionComplex}}, DoublePrecision}, "abs"},
{{"cdcos", {{"a", DoublePrecisionComplex}}, DoublePrecisionComplex}, "cos"}, {{"cdcos", {{"x", DoublePrecisionComplex}}, DoublePrecisionComplex}, "cos"},
{{"cdexp", {{"a", DoublePrecisionComplex}}, DoublePrecisionComplex}, "exp"}, {{"cdexp", {{"x", DoublePrecisionComplex}}, DoublePrecisionComplex}, "exp"},
{{"cdlog", {{"a", DoublePrecisionComplex}}, DoublePrecisionComplex}, "log"}, {{"cdlog", {{"x", DoublePrecisionComplex}}, DoublePrecisionComplex}, "log"},
{{"cdsin", {{"a", DoublePrecisionComplex}}, DoublePrecisionComplex}, "sin"}, {{"cdsin", {{"x", DoublePrecisionComplex}}, DoublePrecisionComplex}, "sin"},
{{"cdsqrt", {{"a", DoublePrecisionComplex}}, DoublePrecisionComplex}, {{"cdsqrt", {{"x", DoublePrecisionComplex}}, DoublePrecisionComplex},
"sqrt"}, "sqrt"},
{{"cexp", {{"a", DefaultComplex}}, DefaultComplex}, "exp"}, {{"cexp", {{"x", DefaultComplex}}, DefaultComplex}, "exp"},
{{"clog", {{"a", DefaultComplex}}, DefaultComplex}, "log"}, {{"clog", {{"x", DefaultComplex}}, DefaultComplex}, "log"},
{{"conjg", {{"a", DefaultComplex}}, DefaultComplex}}, {{"conjg", {{"z", DefaultComplex}}, DefaultComplex}},
{{"cos", {{"x", DefaultReal}}, DefaultReal}}, {{"cos", {{"x", DefaultReal}}, DefaultReal}},
{{"cosh", {{"x", DefaultReal}}, DefaultReal}}, {{"cosh", {{"x", DefaultReal}}, DefaultReal}},
{{"csin", {{"a", DefaultComplex}}, DefaultComplex}, "sin"}, {{"csin", {{"x", DefaultComplex}}, DefaultComplex}, "sin"},
{{"csqrt", {{"a", DefaultComplex}}, DefaultComplex}, "sqrt"}, {{"csqrt", {{"x", DefaultComplex}}, DefaultComplex}, "sqrt"},
{{"ctan", {{"a", DefaultComplex}}, DefaultComplex}, "tan"}, {{"ctan", {{"x", DefaultComplex}}, DefaultComplex}, "tan"},
{{"dabs", {{"a", DoublePrecision}}, DoublePrecision}, "abs"}, {{"dabs", {{"a", DoublePrecision}}, DoublePrecision}, "abs"},
{{"dacos", {{"x", DoublePrecision}}, DoublePrecision}, "acos"}, {{"dacos", {{"x", DoublePrecision}}, DoublePrecision}, "acos"},
{{"dasin", {{"x", DoublePrecision}}, DoublePrecision}, "asin"}, {{"dasin", {{"x", DoublePrecision}}, DoublePrecision}, "asin"},
Context not available.
{"y", AnyIntOrReal, Rank::elementalOrBOZ, Optionality::optional}}, {"y", AnyIntOrReal, Rank::elementalOrBOZ, Optionality::optional}},
DoublePrecisionComplex}, DoublePrecisionComplex},
"cmplx", true}, "cmplx", true},
{{"dconjg", {{"a", AnyComplex}}, DoublePrecisionComplex}, "conjg"}, {{"dconjg", {{"z", AnyComplex}}, DoublePrecisionComplex}, "conjg"},
{{"dcos", {{"x", DoublePrecision}}, DoublePrecision}, "cos"}, {{"dcos", {{"x", DoublePrecision}}, DoublePrecision}, "cos"},
{{"dcosh", {{"x", DoublePrecision}}, DoublePrecision}, "cosh"}, {{"dcosh", {{"x", DoublePrecision}}, DoublePrecision}, "cosh"},
{{"ddim", {{"x", DoublePrecision}, {"y", DoublePrecision}}, {{"ddim", {{"x", DoublePrecision}, {"y", DoublePrecision}},
DoublePrecision}, DoublePrecision},
"dim"}, "dim"},
{{"dexp", {{"x", DoublePrecision}}, DoublePrecision}, "exp"}, {{"dexp", {{"x", DoublePrecision}}, DoublePrecision}, "exp"},
{{"dfloat", {{"i", AnyInt}}, DoublePrecision}, "real", true}, {{"dfloat", {{"a", AnyInt}}, DoublePrecision}, "real", true},
{{"dim", {{"x", DefaultReal}, {"y", DefaultReal}}, DefaultReal}}, {{"dim", {{"x", DefaultReal}, {"y", DefaultReal}}, DefaultReal}},
{{"dimag", {{"a", AnyComplex}}, DoublePrecision}, "aimag"}, {{"dimag", {{"z", AnyComplex}}, DoublePrecision}, "aimag"},
{{"dint", {{"a", DoublePrecision}}, DoublePrecision}, "aint"}, {{"dint", {{"a", DoublePrecision}}, DoublePrecision}, "aint"},
{{"dlog", {{"x", DoublePrecision}}, DoublePrecision}, "log"}, {{"dlog", {{"x", DoublePrecision}}, DoublePrecision}, "log"},
{{"dlog10", {{"x", DoublePrecision}}, DoublePrecision}, "log10"}, {{"dlog10", {{"x", DoublePrecision}}, DoublePrecision}, "log10"},
Context not available.
{{"dtan", {{"x", DoublePrecision}}, DoublePrecision}, "tan"}, {{"dtan", {{"x", DoublePrecision}}, DoublePrecision}, "tan"},
{{"dtanh", {{"x", DoublePrecision}}, DoublePrecision}, "tanh"}, {{"dtanh", {{"x", DoublePrecision}}, DoublePrecision}, "tanh"},
{{"exp", {{"x", DefaultReal}}, DefaultReal}}, {{"exp", {{"x", DefaultReal}}, DefaultReal}},
{{"float", {{"i", AnyInt}}, DefaultReal}, "real", true}, {{"float", {{"a", AnyInt}}, DefaultReal}, "real", true},
{{"iabs", {{"a", DefaultInt}}, DefaultInt}, "abs"}, {{"iabs", {{"a", DefaultInt}}, DefaultInt}, "abs"},
{{"idim", {{"x", DefaultInt}, {"y", DefaultInt}}, DefaultInt}, "dim"}, {{"idim", {{"x", DefaultInt}, {"y", DefaultInt}}, DefaultInt}, "dim"},
{{"idint", {{"a", AnyReal}}, DefaultInt}, "int", true}, {{"idint", {{"a", AnyReal}}, DefaultInt}, "int", true},
Context not available.