This is an archive of the discontinued LLVM Phabricator instance.

[doc] Add llvm-ifs commandline guide
ClosedPublic

Authored by haowei on Jan 28 2022, 3:33 PM.

Details

Reviewers
phosek
shayba
Summary

This patch adds llvm-ifs commandline guide

Diff Detail

Event Timeline

haowei created this revision.Jan 28 2022, 3:33 PM
haowei requested review of this revision.Jan 28 2022, 3:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 3:33 PM
phosek added inline comments.Feb 8 2022, 1:39 AM
llvm/docs/CommandGuide/llvm-ifs.rst
18–21

Consider this.

28
47

I'd format these as code.

73–76
88

These should be formatted as code.

107

I'm not sure if it's guaranteed, but we've confirmed it to be the case.

133

This should be formatted as code, the same for other fields below.

haowei updated this revision to Diff 406955.Feb 8 2022, 1:29 PM
haowei marked 5 inline comments as done.
phosek accepted this revision.Feb 26 2022, 11:28 PM

LGTM. Can you also file an issue to have this change backported to 14.0.0 release branch?

llvm/docs/CommandGuide/llvm-ifs.rst
92–100

Can you format these as code as well?

This revision is now accepted and ready to land.Feb 26 2022, 11:28 PM
haowei updated this revision to Diff 411849.Feb 28 2022, 11:11 AM
haowei marked an inline comment as done.
haowei closed this revision.Nov 9 2022, 11:33 AM

Patch was already landed. Not sure why it is not auto closed. Close it now.

Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2022, 11:33 AM