This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Fix ORCv2 C Binding
ClosedPublic

Authored by leifhelm on Jan 28 2022, 2:18 AM.

Details

Summary

The LLVMOrcObjectLayerAddObjectFileWithRT method does not have an implementation. LLVMOrcLLJITAddObjectFileWithRT exists twice (maybe a copy paste error).

Diff Detail

Event Timeline

leifhelm created this revision.Jan 28 2022, 2:18 AM
leifhelm requested review of this revision.Jan 28 2022, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 2:18 AM
lattner resigned from this revision.Jan 28 2022, 8:31 AM

@lhames would be the best reviewer for this.

lhames accepted this revision.Apr 1 2022, 9:11 PM

LGTM. Thanks Jakob!

What name / email would you like me to use for the patch attribution?

This revision is now accepted and ready to land.Apr 1 2022, 9:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 9:11 PM
Herald added a subscriber: StephenFan. · View Herald Transcript

Thanks for reviewing this.
Use Jakob Leifhelm and jakob.leifhelm@gmail.com for the attribution.

This revision was landed with ongoing or failed builds.Mar 27 2023, 4:08 PM
This revision was automatically updated to reflect the committed changes.