This is an archive of the discontinued LLVM Phabricator instance.

Differential D118389

[libc] Guard sqrt_80_bit_long_double.h header to not be included with aarch64.
ClosedPublic

Authored by lntue on Jan 27 2022, 9:16 AM.

Details

Reviewers
sivachandra
Commits
rG4a979c42564e: [libc] Guard sqrt_80_bit_long_double.h header to not be included with aarch64.
Summary

Guard sqrt_80_bit_long_double.h header to not be included with aarch64.

Diff Detail

Event Timeline

lntue created this revision.Jan 27 2022, 9:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2022, 9:16 AM
Herald added subscribers: ecnelises, tschuett, kristof.beyls. · View Herald Transcript
lntue requested review of this revision.Jan 27 2022, 9:16 AM
sivachandra added inline comments.Jan 27 2022, 9:48 AM
libc/src/__support/FPUtil/generic/sqrt.h
23

Do we really want this include from inside of a namespace?

lntue updated this revision to Diff 403715.Jan 27 2022, 10:04 AM

Move the include out of the namespaces.

lntue marked an inline comment as done.Jan 27 2022, 10:04 AM
sivachandra accepted this revision.Jan 27 2022, 10:29 AM
This revision is now accepted and ready to land.Jan 27 2022, 10:29 AM
This revision was landed with ongoing or failed builds.Jan 27 2022, 10:36 AM
Closed by commit rG4a979c42564e: [libc] Guard sqrt_80_bit_long_double.h header to not be included with aarch64. (authored by lntue). · Explain Why
This revision was automatically updated to reflect the committed changes.
lntue added a commit: rG4a979c42564e: [libc] Guard sqrt_80_bit_long_double.h header to not be included with aarch64..
Harbormaster completed remote builds in B146082: Diff 403715.Jan 27 2022, 1:04 PM
sivachandra added a reverting change: rGfdd4269f2e0c: [libc] Revert "Guard sqrt_80_bit_long_double.h header to not be included with….Jan 27 2022, 1:11 PM

Revision Contents

PathSize
libc/
src/
__support/
FPUtil/
generic/
3 lines

Diff 403695

libc/src/__support/FPUtil/generic/sqrt.h

//===-- Square root of IEEE 754 floating point numbers ----------*- C++ -*-===// //===-- Square root of IEEE 754 floating point numbers ----------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_SUPPORT_FPUTIL_GENERIC_SQRT_H #ifndef LLVM_LIBC_SRC_SUPPORT_FPUTIL_GENERIC_SQRT_H
#define LLVM_LIBC_SRC_SUPPORT_FPUTIL_GENERIC_SQRT_H #define LLVM_LIBC_SRC_SUPPORT_FPUTIL_GENERIC_SQRT_H
#include "sqrt_80_bit_long_double.h"
#include "src/__support/CPP/TypeTraits.h" #include "src/__support/CPP/TypeTraits.h"
#include "src/__support/FPUtil/FEnvImpl.h" #include "src/__support/FPUtil/FEnvImpl.h"
#include "src/__support/FPUtil/FPBits.h" #include "src/__support/FPUtil/FPBits.h"
#include "src/__support/FPUtil/PlatformDefs.h" #include "src/__support/FPUtil/PlatformDefs.h"
namespace __llvm_libc { namespace __llvm_libc {
namespace fputil { namespace fputil {
namespace internal { namespace internal {
#if defined(SPECIAL_X86_LONG_DOUBLE) #if defined(SPECIAL_X86_LONG_DOUBLE)
#include "sqrt_80_bit_long_double.h"
sivachandraUnsubmitted
Done
ReplyInline Actions

Do we really want this include from inside of a namespace?

sivachandra: Do we really want this include from inside of a namespace?
struct SpecialLongDouble { struct SpecialLongDouble {
static constexpr bool VALUE = true; static constexpr bool VALUE = true;
}; };
#else #else
struct SpecialLongDouble { struct SpecialLongDouble {
static constexpr bool VALUE = false; static constexpr bool VALUE = false;
}; };
#endif // SPECIAL_X86_LONG_DOUBLE #endif // SPECIAL_X86_LONG_DOUBLE
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines