This is an archive of the discontinued LLVM Phabricator instance.

[test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler when compiling test-suite tools.
ClosedPublic

Authored by amyk on Jan 27 2022, 5:49 AM.

Details

Summary

The tools used by test-suite are originally configured to compile with cc by default,
and this is dictated by TEST_SUITE_HOST_CC.
However, it is possible that on some systems that the version of cc may either not be
present or it may not be able to compile the tools as it may be too old, which could be
an issue seen during release testing.

This patch updates the compiler to be the default build compiler that is used for release
testing. If no such compiler it specified, then cc will be set as the test-suite tools build
compiler by default (as it already is set under TEST_SUITE_HOST_CC).

Diff Detail

Event Timeline

amyk requested review of this revision.Jan 27 2022, 5:49 AM
amyk created this revision.
nemanjai accepted this revision.Jan 31 2022, 5:48 AM

LGTM. But maybe wait for a few days in case others have objections.

This revision is now accepted and ready to land.Jan 31 2022, 5:48 AM
amyk added a comment.Feb 3 2022, 1:25 PM

@tstellar Just wanted to double check with you in case you had any objections to this patch. I'd like to commit it and would also like it added to the release branch (after it's committed).

tstellar accepted this revision.Feb 3 2022, 1:28 PM

This seems fine.

This revision was landed with ongoing or failed builds.Feb 3 2022, 7:32 PM
This revision was automatically updated to reflect the committed changes.
amyk added a comment.Feb 4 2022, 8:21 AM

This seems fine.

Thanks @tstellar. Can https://reviews.llvm.org/rG413b35cd74e42f6371641bc9dc6c707aedac82ff also be added to the release 14 branch?