[ORC][AArch64] use isInt<N> to replace fitsRangeSignedInt on aarch64

[dongAxis1944]

Summary

summary

This is the first path to support more relocation types on aarch64.
 The patch just uses the isInt<N> to replace fitsRangeSignedInt.

Test Plan:

check-all

[dongAxis1944]

update patch

[sgraenitz]

This is from llvm/Support/MathExtras.h right? Can you add it as an explicit include please? Otherwise LGTM.

[dongAxis1944]

In D118231#3272243, @sgraenitz wrote:

This is from llvm/Support/MathExtras.h right? Can you add it as an explicit include please? Otherwise LGTM.

ok, i will include the header.

llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp

Error applyFixup(LinkGraph &G, Block &B, const Edge &E) const {
     case aarch64::R_AARCH64_CALL26: {
       assert((FixupAddress.getValue() & 0x3) == 0 &&
              "Call-inst is not 32-bit aligned");
       int64_t Value = E.getTarget().getAddress() - FixupAddress + E.getAddend();
 
       if (static_cast<uint64_t>(Value) & 0x3)
         return make_error<JITLinkError>("Call target is not 32-bit aligned");
 
-      if (!fitsRangeSignedInt<27>(Value))
+      if (!isInt<28>(Value))
         return makeTargetOutOfRangeError(G, B, E);
 
       uint32_t RawInstr = *(little32_t *)FixupPtr;
       assert((RawInstr & 0x7fffffff) == 0x14000000 &&
              "RawInstr isn't a B or BR immediate instruction");
       uint32_t Imm = (static_cast<uint32_t>(Value) & ((1 << 28) - 1)) >> 2;
       uint32_t FixedInstr = RawInstr | Imm;
       *(little32_t *)FixupPtr = FixedInstr;
       break;
     }
     }
     return Error::success();
   }
-
-  template <uint8_t Bits> static bool fitsRangeSignedInt(int64_t Value) {
-    return Value >= -(1ll << Bits) && Value < (1ll << Bits);
-  }
 };
 
 template <typename ELFT>
 class ELFLinkGraphBuilder_aarch64 : public ELFLinkGraphBuilder<ELFT> {
 private:
   static Expected<aarch64::EdgeKind_aarch64>
   getRelocationKind(const uint32_t Type) {
     using namespace aarch64;